[action] [PR:9075] [chassis] accomodate test_memory_exhaustion.py if random dut is chassis sup #9295
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Original PR: #9075 |
|
@wenyiz2021 @arlakshm This PR cause an issue. wait_lc_healthy_if_sup() has been defined with 3 arguments. But the cause only given 3. |
mlok-nokia
reviewed
Aug 7, 2023
| @@ -41,6 +49,7 @@ def tearDown(self, duthosts, enum_rand_one_per_hwsku_hostname, localhost, pdu_co | |||
| 'Recover {} by PDU reboot failed'.format(hostname)) | |||
| # Wait until all critical processes are healthy. | |||
| wait_critical_processes(duthost) | |||
| self.wait_lc_healthy_if_sup(duthost, duthosts) | |||
There was a problem hiding this comment.
wait_lc_healthy_if_sup() missing localhost as an argument
mlok-nokia
reviewed
Aug 7, 2023
| @@ -68,6 +77,7 @@ def test_memory_exhaustion(self, duthosts, enum_rand_one_per_hwsku_hostname, loc | |||
| 'DUT {} did not startup'.format(hostname)) | |||
| # Wait until all critical processes are healthy. | |||
| wait_critical_processes(duthost) | |||
| self.wait_lc_healthy_if_sup(duthost, duthosts) | |||
There was a problem hiding this comment.
wait_lc_healthy_if_sup missing localhost as an argument.
thanks @mlok-nokia for catching this! I raised a fix PR #9320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
There are 2 fixes in this PR to enhance for chassis:
Summary:
Fixes # (issue)
#9087
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation