Skip to content

testcase for bgp container in container hardening #8694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2023
Merged

testcase for bgp container in container hardening #8694

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68b048c
test container hardening
maipbui Jun 22, 2023
faf467f
address comments
maipbui Jun 23, 2023
cdf6957
add test to python3 test files
maipbui Jun 23, 2023
8cf6217
address comments
maipbui Jun 28, 2023
28f3c99
Merge branch 'master' into bgp_dev
maipbui Jul 5, 2023
5ba3fa6
make test generic
maipbui Jul 5, 2023
fd940fa
address comments
maipbui Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/container_hardening/test_container_hardening.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import pytest
import logging
from tests.common.helpers.assertions import pytest_assert

pytestmark = [
pytest.mark.topology('any'),
]

logger = logging.getLogger(__name__)


def test_bgp_dev(duthost):
"""
Test bgp container has no access to /dev/vda* or /dev/sda*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test related to the --privileged flag removal or net=host?
I think we should mention this and also change the name of the test to accommodate it.
Also - in the future, I think we should make this test generic for any container that wants to test their solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yarden-Z it's related to test --privileged flag, I modified the test to make it generic.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good improvement.
I think that in the future we can make this test even more generic.
i.e - maintain a list of containers that do not have the --privileged flag. (define this list in some global or maintain it in the section of container hardening)
Then - for each container (name) in this list, iterate on top of them and execute this test. That way - we won't need the if case and we'll be able to scale this test for each new container.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed your comment, thanks

"""
device = duthost.shell("docker exec bgp bash -c 'df -h | grep /etc/hosts' | awk '{print $1}'")['stdout']
Copy link
Contributor

@qiluo-msft qiluo-msft Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device

Will you check shell return code, and device is a valid path? If not, there may be risk to be inject into another command. #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked return code and valid path for device

output = duthost.shell("docker exec bgp bash -c 'ls {}'".format(device), module_ignore_errors=True)['stdout']
pytest_assert(not output, 'The partition {} exists.'.format(device))
1 change: 1 addition & 0 deletions tests/python3_test_files.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ console/test_console_loopback.py
console/test_console_reversessh.py
console/test_console_udevrule.py
container_checker/test_container_checker.py
container_hardening/test_container_hardening.py
copp/test_copp.py
crm/test_crm.py
dash/test_dash_vnet.py
Expand Down