Skip to content

Refine critical process monitor wait time logic #8116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

yejianquan
Copy link
Collaborator

Description of PR

Summary:
Refine the wait time of test_critical_process_monitoring.py, wait for 90s on KVM duts but only waiting for 70s on physical duts to avoid the syncd delay issue being missed.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Refine the wait time of test_critical_process_monitoring.py, wait for 90s on KVM duts but only waiting for 70s on physical duts to avoid the syncd delay issue being missed.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit bd7d850 into sonic-net:master Apr 24, 2023
yejianquan added a commit that referenced this pull request Apr 24, 2023
Approach
What is the motivation for this PR?
Refine the wait time of test_critical_process_monitoring.py, wait for 90s on KVM duts but only waiting for 70s on physical duts to avoid the syncd delay issue being missed.

co-authorized by: [email protected]
mrkcmo pushed a commit to Azarack/sonic-mgmt that referenced this pull request Oct 3, 2023
Approach
What is the motivation for this PR?
Refine the wait time of test_critical_process_monitoring.py, wait for 90s on KVM duts but only waiting for 70s on physical duts to avoid the syncd delay issue being missed.

co-authorized by: [email protected]
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
Approach
What is the motivation for this PR?
Refine the wait time of test_critical_process_monitoring.py, wait for 90s on KVM duts but only waiting for 70s on physical duts to avoid the syncd delay issue being missed.

co-authorized by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants