-
Notifications
You must be signed in to change notification settings - Fork 851
[Advanced_reboot] Add test for two loopbacks in warm reboot test #7324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -617,7 +621,9 @@ def setUp(self): | |||
|
|||
self.generate_from_t1() | |||
self.generate_from_vlan() | |||
self.generate_ping_dut_lo() | |||
self.generate_ping_dut_lo(self.lo_prefix) | |||
#if self.lo_prefix2 != '': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is commented. I think we do want to call generate_ping_dut_lo
with second lo.
@@ -50,6 +50,10 @@ def __init__(self, request, duthosts, duthost, ptfhost, localhost, tbinfo, creds | |||
'service-warm-restart' in kwargs['rebootType']), \ | |||
"Please set rebootType var." | |||
|
|||
sonic_hwsku = duthost.sonichost.facts["hwsku"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part (skipping on 3800) is not relevant to the PR. Please remove.
@@ -673,6 +680,7 @@ def __runPtfRunner(self, rebootOper=None): | |||
"dut_mac": self.rebootData['dut_mac'], | |||
"vlan_mac": self.rebootData['vlan_mac'], | |||
"lo_prefix": self.rebootData['lo_prefix'], | |||
"lo_prefix2": self.rebootData['lo_prefix2'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will throw KeyError when lo_prefix2
key is not found in dict. That can happen when len(self.mgFacts['minigraph_lo_interfaces']) <= 1
Added some comments. Also, let's wait to merge this PR until the test_advanced_reboot is added as part of PR tests. |
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fill warm-reboot test gap for when there are two loopback addresses
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation