[GCU E2E test] add stop pfcwd test #7308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
previously approved these changes
Jan 21, 2023
neethajohn
reviewed
Jan 24, 2023
Comment on lines
+133
to
+156
| json_patch = [ | ||
| { | ||
| "op": "remove", | ||
| "path": "/PFC_WD/{}/detection_time".format(interface), | ||
| }, | ||
| { | ||
| "op": "remove", | ||
| "path": "/PFC_WD/{}/restoration_time".format(interface), | ||
| }, | ||
| { | ||
| "op": "remove", | ||
| "path": "/PFC_WD/{}/action".format(interface) | ||
| } | ||
| ] | ||
|
|
||
| try: | ||
| tmpfile = generate_tmpfile(duthost) | ||
| output = apply_patch(duthost, json_data=json_patch, dest_file=tmpfile) | ||
| expect_op_success(duthost, output) | ||
| pfcwd_updated_config = duthost.shell("show pfcwd config") | ||
| pytest_assert(not pfcwd_config['rc'], "Unable to read updated pfcwd config") | ||
| pytest_assert(interface not in pfcwd_updated_config['stdout'].split(), "pfcwd unexpectedly still running on interface {}".format(interface)) | ||
| finally: | ||
| delete_tmpfile(duthost, tmpfile) |
There was a problem hiding this comment.
this whole code needs to be indented. Needs to move under the 'for' block
There was a problem hiding this comment.
This test only intends to test one interface, as the flow would be the same for all interfaces. I added a break statement to the for loop to stop once the first interface is identified for test
qiluo-msft
reviewed
Jan 25, 2023
qiluo-msft
approved these changes
Jan 27, 2023
kellyyeh
pushed a commit
to kellyyeh/sonic-mgmt
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add GCU E2E test for case where we stop pfcwd on specific port
How did you do it?
How did you verify/test it?
Run E2E test on physical DUT
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation