[SSH] Fix SSH login session limit test case randomly failed issue. #5426 #5516
Conversation
tests/ssh/test_ssh_limit.py
Outdated
| # run update template command and wait for template updated | ||
| config_file_content = [] | ||
| while len(config_file_content) == 0: | ||
| stdin, stdout, stderr = admin_session.exec_command(LIMITS_CONF_TEMPLATE.format(hwsku, type, additional_content, template_path)) |
There was a problem hiding this comment.
This command sometimes will fail without error. can only randomly reproduce on testbed KVM.
There was a problem hiding this comment.
Re-run few times, all test passed:
ssh/test_ssh_limit.py::test_ssh_limits[] PASSED [100%]
There was a problem hiding this comment.
Could you explain in details "This command sometimes will fail without error" in PR description? If there is no error, why bothering fix.
There was a problem hiding this comment.
Fixed by remove the tee command. also decription updated.
The UT randomly failed because the template file not update, I found somestackover folow discussion about tee command will exist early when receive pipeline close signel.
|
This pull request introduces 3 alerts when merging b598111 into 85e608b - view on LGTM.com new alerts:
|
liuh-80
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description of PR
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix SSH login session limit test case randomly failed issue.
How did you do it?
Code change:
1. Not use tee command to update template file in template folder.
2. Create template file with pipeline in home folder and move to template folder.
How did you verify/test it?
Run new UT make sure they are all pass.
Make sure all current UT not break during merge validation.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?