egress Everflow tests: added a missing destination route for original flow #4850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a missing destinatio route Tests checking the Everflow feature on egress stage rely on a default static route to forward packets but the route was removed recently from SONiC so packets get dropped and mirroring is skipped. The route removed in sonic-net/sonic-buildimage#9182
|
The change makes sense to me. Only one question, why not apply this fixture to other EGRESS test? |
good point, thanks ! I've applied the corresponding fixture to all tests with egress ACLs |
bingwang-ms
approved these changes
Dec 20, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
… flow (sonic-net#4850) * fixed egress Everflow tests - added a missing destination route Tests checking the Everflow feature on egress stage rely on a default static route to forward packets but the route was removed recently from SONiC so packets get dropped and mirroring is skipped. The route removed in sonic-net/sonic-buildimage#9182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: egress Everflow tests - added a missing destination route for original flow
Fixes # (issue)
Tests checking the Everflow feature on egress stage rely on a default static route to forward original flow packets but the route was removed recently from SONiC causing packets drop. This prevents Everflow on egress to happen so tests fail expecting mirrored packets. The required route was setup to fix it
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix failing egress Everflow tests
How did you do it?
Setup the required route for original packet flow
How did you verify/test it?
py.test --inventory=../ansible/lab,../ansible/veos --testbed_file=../ansible/testbed.csv --module-path=../ansible/library -v -rA --topology=t1,any test_everflow_testbed.py::TestEverflowV4EgressAclEgressMirror -k test_everflow_basic_forwarding
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation