Add wait_until for ARP population on linkflap testcase in test_voq_nbr.py #19344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the same wait_until that is used in other testcases in the test module for ARP repopulation Signed-off-by: Javier Tan [email protected]
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
YatishSVC
approved these changes
Jul 2, 2025
tjchadaga
approved these changes
Jul 2, 2025
Janetxxx
approved these changes
Jul 3, 2025
arlakshm
reviewed
Jul 3, 2025
…re pinged * Move neighbor in ARP check to after all neighbors are pinged Signed-off-by: Javier Tan [email protected]
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Fix logging typo in assert Signed-off-by: Javier Tan [email protected]
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LinJin23
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #19331
Type of change
Back port request
Approach
What is the motivation for this PR?
(From #19331) Fix testcase
voq/test_voq_nbr.py::TestNeighborLinkFlap::test_front_panel_linkflap_portfails on conditiontable state delay is not reachable. This is because the test expects the ARP table to update instantly fromSTALEtoREACHABLEafter a ping is sent, which is the case for non-portchannel interfaces, however there is a small 2-3s delay state for portchannel interfacesSTALE->DELAY(2-3s) ->REACHABLEHow did you do it?
Implement a
wait_untilfor ARP repopulation after a linkflap, similar to other testcases in the same test moduleHow did you verify/test it?
Ran it 5 times to ensure it's not flaky. https://elastictest.org/scheduler/testplan/6865300c3d76d955497fbe94?leftSideViewMode=detail
3x pass on minor iteration: https://elastictest.org/scheduler/testplan/686635aa6bbbe4a384a7bfd6
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A