Skip to content

[202411] Ignore loganaylzer errors about the leapsecond file being expired #19285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 202411
Choose a base branch
from

Conversation

saiarcot895
Copy link
Contributor

@saiarcot895 saiarcot895 commented Jul 1, 2025

Description of PR

Summary:

Fixes sonic-net/sonic-buildimage#23142
Fixes sonic-net/sonic-buildimage#17653
Fixes sonic-net/sonic-buildimage#11327

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Depending on the image that is running, when it was built, and what version of packages were used, the leapsecond file might be expired. Ignore errors from ntpd about it, since the only functional impact that it might cause is that if there is a leapsecond, the system clock will be off by a second for a little bit until it gets corrected.

How did you do it?

Add a loganalyzer pattern to ignore such error messages.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Depending on the image that is running, when it was built, and what
version of packages were used, the leapsecond fil might be expired.
Ignore errors from ntpd about it, since the only functional impact that
it might cause is that if there is a leapsecond, the system clock will
be off by a second for a little bit until it gets corrected.

Signed-off-by: Saikrishna Arcot <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rminnikanti
Copy link
Contributor

@saiarcot895 there is already a ignore regex at line309 which isn't working. Pasted here:

# ignore leap second file NTP daemon (ntpd) is using has passed its expiration date
r, ".* ERR ntpd\[\d*\]:.*leapsecond file ('/usr/share/zoneinfo/leap-seconds.list'): expired.*"

We can either remove it or fix it and make it work.

Also, is this change only being made to 202411 branch?

@sanjair-git
Copy link
Contributor

We are seeing this issue in 202503 release branch as well. Can you please add Request label for 202503 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants