Skip test_cacl_application for PR test temporarily #18785
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhaohui Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Jun 4, 2025
bpar9
approved these changes
Jun 4, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 4, 2025
Description of PR Summary: Fixes # (issue) sonic-net/sonic-host-services#197 added a new change for caclmgrd, PR test for submodule advanced PR of sonic-host-services failed. Disable test_cacl_application in PR test temporarily for merging submodule PR. > pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}" .format(repr(missing_iptables_rules))) E Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'} For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps: skip test_cacl_application from PR test imagebuild PR get merged update test case add test_cacl_application back for PR test Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? sonic-net/sonic-host-services#197 added a new change for caclmgrd, PR test for submodule advanced PR of sonic-host-services failed. How did you do it? Disable test_cacl_application in PR test temporarily for merging submodule PR. How did you verify/test it? Retrigger PR test for sonic-host-services submodule advance PR. Signed-off-by: Zhaohui Sun <[email protected]>
|
Cherry-pick PR to 202505: #18791 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 4, 2025
Description of PR Summary: Fixes # (issue) sonic-net/sonic-host-services#197 added a new change for caclmgrd, PR test for submodule advanced PR of sonic-host-services failed. Disable test_cacl_application in PR test temporarily for merging submodule PR. > pytest_assert(len(missing_iptables_rules) == 0, "Missing expected iptables rules: {}" .format(repr(missing_iptables_rules))) E Failed: Missing expected iptables rules: {'-A INPUT -p tcp -m tcp --dport 179 -j ACCEPT'} For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps: skip test_cacl_application from PR test imagebuild PR get merged update test case add test_cacl_application back for PR test Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? sonic-net/sonic-host-services#197 added a new change for caclmgrd, PR test for submodule advanced PR of sonic-host-services failed. How did you do it? Disable test_cacl_application in PR test temporarily for merging submodule PR. How did you verify/test it? Retrigger PR test for sonic-host-services submodule advance PR. Signed-off-by: Zhaohui Sun <[email protected]>
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.
Disable test_cacl_application in PR test temporarily for merging submodule PR.
For any changes in caclmgrd, if it will fail test_cacl_application case, need to follow the steps:
Type of change
Back port request
Approach
What is the motivation for this PR?
sonic-net/sonic-host-services#197 added a new change for caclmgrd,
PR test for submodule advanced PR of sonic-host-services failed.
How did you do it?
Disable test_cacl_application in PR test temporarily for merging submodule PR.
How did you verify/test it?
Retrigger PR test for sonic-host-services submodule advance PR.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation