-
Notifications
You must be signed in to change notification settings - Fork 817
[test gap] Add a new case to check caclmgrd syslog #17143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test gap] Add a new case to check caclmgrd syslog #17143
Conversation
Signed-off-by: Zhaohui Sun <[email protected]>
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Signed-off-by: Zhaohui Sun <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the motivation for this PR? A new test case to check if INFO logs of caclmgrd was printed into syslog successfully. How did you do it? rotate syslog restart caclmgrd check if iptables syslog existing in syslog file Check if iptables rules are applied successfully in the output of systemctl status caclmgrd How did you verify/test it? Run the new test case on the testbed
What is the motivation for this PR? A new test case to check if INFO logs of caclmgrd was printed into syslog successfully. How did you do it? rotate syslog restart caclmgrd check if iptables syslog existing in syslog file Check if iptables rules are applied successfully in the output of systemctl status caclmgrd How did you verify/test it? Run the new test case on the testbed
Hi @ZhaohuiS , |
@echuawu which platform did it fail? On which version? |
|
@echuawu what's the output of "sudo iptables -S" in your testing? |
Hi @ZhaohuiS,
And there are the output of "iptables -S":
There is no NAT rules found. |
hi @ZhaohuiS , do you have any updates? |
@echuawu In your case, you need to check "sudo iptables -t nat -S", the iptable rules are there. |
Update it in #18239 |
Description of PR
Summary:
Fixes # (issue)
To address #16548.
The issue sonic-net/sonic-buildimage#21290, the issue of INFO level logs disappear in caclmgrd was reported after the commit got merged months later.
We need a test case to help us report this kind of issue earlier.
Type of change
Back port request
Approach
What is the motivation for this PR?
A new test case to check if INFO logs of caclmgrd was printed into syslog successfully.
How did you do it?
How did you verify/test it?
Run the new test case on the testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation