[platform] Fix the test_status_led error in case if the chassis led is not controllable #16936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not controllable Signed-off-by: vhlushko <[email protected]>
|
/azp run |
The committers listed above are authorized under a signed CLA. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Need to cherry-pick this to the 202405 branch as well. |
bpar9
approved these changes
Feb 12, 2025
|
@bpar9 could you please merge? |
|
@prgeor - could you review this? |
|
@bpar9 could you please put a label |
|
@prgeor - could you please review this? |
|
@judyjoseph to review |
|
@judyjoseph kind reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix the test_status_led error in case if the chassis led is not controllable
Type of change
Back port request
Approach
What is the motivation for this PR?
The platform_tests/api/test_chassis.py::test_status_led testcase code logic assumes that the chassis main led is always controllable.
But for some of the Cisco devices this test logic:
always returns
None, which means that the chassis led is not controllable. That is why I introduce such change - to assume on default that the chassis led is not controllable.How did you do it?
Change the
led_controllable = Falsevariable value.How did you verify/test it?
Run the
platform_tests/api/test_chassis.py.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation