[Platform_tests/test_watchdog]: Added platform check to disarm watchdog for nokia_ixs7215 #10082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Blueve Please check this PR for the newly implemented watchdog service. |
|
@prgeor I think we might need refactor this in future if the watchdog enablement can be configurable for a platform. We might need a new platform API to check if the platform enabled watchdog by default then the test can make decision smartly |
Blueve
approved these changes
Oct 11, 2023
|
Merge after sonic-net/sonic-buildimage#16612 completed |
11 tasks
|
@Blueve @yxieca We can merge this PR now that sonic-net/sonic-buildimage#16612 is Merged |
Merged
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 18, 2023
|
Cherry-pick PR to 202305: #11046 |
6 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 18, 2023
|
Cherry-pick PR to 202205: #11051 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 18, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Dec 18, 2023
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back port request
Approach
What is the motivation for this PR?
Since watchdog was implemented in Nokia 7215, the api testcase 'test_watchdog' needs additional improvements. The test checks if watchdog is disarmed before running the tests. Since watchdog has now been implemented in Nokia 7215 platform as a service (cpu_wdt.service), watchdog will be armed. The watchdog api tests fail as watchdog is already armed.
How did you do it?
The addition here to check if the platform is 'armhf-nokia_ixs7215_52x-r0' and then disarm the watchdog before the tests start. Once watchdog is disarmed, watchdog api tests will run successfully. After these testcases are complete, we arm the watchdog again by starting the cpu_wdt.service.
How did you verify/test it?
Ran all the watchdog api testcases to verify is they pass. Also checked if the watchdog service is up and running once the testcases are complete.
Any platform specific information?
This conditional check and execution of watchdog disarm and then starting the service after the tests run is specific to nokia 7215 platform.