-
Notifications
You must be signed in to change notification settings - Fork 812
team docker has different names in buildimage and in mgmt #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@stcheng for awareness |
Merged
3 tasks
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this issue
Feb 21, 2025
…tion file. (sonic-net#72) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: The metric 'Rx_L1_rate_Gbps' is picked from traffic item statistics. However, in 10.80, this is not working causing index error. Switching it to Rx_L1_rate_bps in the statistics file. Fixes # (issue) sonic-net#16731 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [X] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [X] 202405 - [X] 202411 ### Approach #### What is the motivation for this PR? Resolving index error in the traffic item statistics. Instead of capturing Gbps rates, which no longer exists, switched to bps rates. #### How did you do it? Single line of code: ``` stats[metric_name+'_Rx_L1_Rate_bps'] = float(metric['Rx L1 Rate (bps)']) ``` #### How did you verify/test it? Local clone. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sonic-buildimage has docker-team directory, and docker with same name is built.
But here it's called docker-teamd.
Which name should be used?
The text was updated successfully, but these errors were encountered: