Fix gNMI IPv6 Get Failures Due to Uncompressed Address Storage #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sauumyaaa
force-pushed
the
uncompressedIPv6FIX
branch
from
c322ff9 to
fbf334e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
Summary
This PR resolves an inconsistency where IPv6 addresses configured via gNMI in uncompressed format were stored as-is in the DB. This behavior broke gnmi_get operations when the same IP was queried in its standard (compressed) form.
Problem Overview
When a user configures an IPv6 address using gNMI, such as:
2001:0db8:abcd:0016::1
…it was stored without compression in the database. This caused:
gnmi_getwith compressed IP (2001:db8:abcd:16::1) → fails with “resource not found”gnmi_getwith the exact (uncompressed) configured IP → succeedsThis inconsistency created confusion and prevented retrieval via normalized XPaths.
Root Cause
The IP string from the gNMI request path was used directly in:
Key formation (YangToDb_subintf_ip_addr_key_xfmr)
Configuration merging (YangToDb_intf_ip_addr_xfmr)
No IP normalization was performed.
Fix
We now normalize all IPv6 addresses using:
net.ParseIP(ip).String()Applied in:
YangToDb_subintf_ip_addr_key_xfmr — for generating consistent keys
YangToDb_intf_ip_addr_xfmr — for normalizing addr.Config.Ip
Testing:
Configured IPv6 address 2001:0db8:abcd:0016::1 via
gnmi_setVerified in Redis that it is stored as 2001:db8:abcd:16::1
Queried via
gnmi_getusing compressed format → successQueried via
gnmi_getusing uncompressed format → fails (as expected)