Skip to content

[backport]: i2c: mux: pca954x: allow management of device idle state via sysfs #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Dec 1, 2020

f1fb64b04b: driver-i2c-mux-pca954x-allow-management-of-device-idle-stat.patch (v5.2-rc1)
ddd7c492d: i2c: mux: pca954x: remove support for unused platform data (v5.2-rc1)

tested on celestica dx010

Signed-off-by: Guohan Lu [email protected]

@paulmenzel
Copy link
Contributor

On what device is this tested?

It’d be great, if you sent a backport request to [email protected], so it gets added to the stable series.

@lguohan
Copy link
Contributor Author

lguohan commented Jan 14, 2021

tested here. sonic-net/sonic-buildimage#6429

@lguohan lguohan marked this pull request as ready for review January 14, 2021 08:06
@paulmenzel
Copy link
Contributor

Thank you for the reference. Commits should still be self-contained, and people cannot be expected to crossreference commits or even repositories. It’d be great, if the Celestica DX010 would be mentioned here too.

Also, I really think a message to [email protected] with the backport request should be sent. (And soon SONiC should switch to Linux 5.10 anyway. ;-))

driver-i2c-mux-pca954x-allow-management-of-device-idle-stat.patch

Signed-off-by: Guohan Lu <[email protected]>
@lguohan
Copy link
Contributor Author

lguohan commented Jan 17, 2021

added the tested message. those patches will be removed 5.2-rc1. I haven't sent patch to [email protected] before. let me see what needs to be done before send to that mailing list.

@lguohan lguohan merged commit 173ebe7 into sonic-net:master Jan 19, 2021
@lguohan lguohan deleted the 954x branch January 19, 2021 08:21
jleveque pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 5, 2021
#### Why I did it
- After [sonic-linux-kernel#177](sonic-net/sonic-linux-kernel#177)  changes, the I2C mux channels of Baseboard and Switchboard CPLDs are moved from i2c-4 and i2c-5 to i2c-36 and i2c-37 respectively.
- This caused QSFP driver initialization of i2c-36 to i2c-41 to fail causing the ports from Ethernet208 to Ethernet248 fail.

#### How I did it
- The fix to this problem is to change the order of QSFP driver initialization to I2C mux channels.
- Instead of the order i2c-10 to i2c-41, the order i2c-4 to i2c-35 is being utilized.
- Also, need to change the i2c-mux-channel number for Baseboard CPLD and switchboard CPLD in scripts to access them.
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 9, 2021
#### Why I did it
- After [sonic-linux-kernel#177](sonic-net/sonic-linux-kernel#177)  changes, the I2C mux channels of Baseboard and Switchboard CPLDs are moved from i2c-4 and i2c-5 to i2c-36 and i2c-37 respectively.
- This caused QSFP driver initialization of i2c-36 to i2c-41 to fail causing the ports from Ethernet208 to Ethernet248 fail.

#### How I did it
- The fix to this problem is to change the order of QSFP driver initialization to I2C mux channels.
- Instead of the order i2c-10 to i2c-41, the order i2c-4 to i2c-35 is being utilized.
- Also, need to change the i2c-mux-channel number for Baseboard CPLD and switchboard CPLD in scripts to access them.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
#### Why I did it
- After [sonic-linux-kernel#177](sonic-net/sonic-linux-kernel#177)  changes, the I2C mux channels of Baseboard and Switchboard CPLDs are moved from i2c-4 and i2c-5 to i2c-36 and i2c-37 respectively.
- This caused QSFP driver initialization of i2c-36 to i2c-41 to fail causing the ports from Ethernet208 to Ethernet248 fail.

#### How I did it
- The fix to this problem is to change the order of QSFP driver initialization to I2C mux channels.
- Instead of the order i2c-10 to i2c-41, the order i2c-4 to i2c-35 is being utilized.
- Also, need to change the i2c-mux-channel number for Baseboard CPLD and switchboard CPLD in scripts to access them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants