Check self's mux mode before switching peer to standby & add support for detach mode
#79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjswhhh
changed the title
detach mode
|
What is |
Updated PR description. |
vdahiya12
reviewed
Jun 2, 2022
| ); | ||
| enterPeerMuxState(label); | ||
| mMuxPortPtr->setPeerMuxState(label); | ||
| startPeerMuxWaitTimer(); |
There was a problem hiding this comment.
for the detach mode, could you please point , where is the actual logic to not query the peer ToR's gRPC API's ?
There was a problem hiding this comment.
Currently querying SELF & PEER is using a same DB table entry. Per offline discussion, will make another PR to separate in the future.
This PR only avoids setting PEER's state.
| ); | ||
| enterPeerMuxState(label); | ||
| mMuxPortPtr->setPeerMuxState(label); | ||
| startPeerMuxWaitTimer(); |
There was a problem hiding this comment.
for the detach mode, could you please point , where is the actual logic to not query the peer ToR's gRPC API's ?
vdahiya12
approved these changes
Jun 6, 2022
|
/AZP run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
that referenced
this pull request
Jun 9, 2022
…for `detach` mode (#79) ### Description of PR Summary: Fixes # (issue) Make sure self ToR is in `auto` mode before switching peer to `standby`. Also add support for `detach` mode. `detach` mode is equal to `auto` mode for SELF, but under this mode, ToR won't touch PEER's status. sign-off: Jing Zhang [email protected] ### Type of change - [x] Bug fix - [x] New feature
zjswhhh
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Oct 7, 2022
What I did Add support for config mux mode detach. Stemming from sonic-net/sonic-linkmgrd#79 sign-off: Jing Zhang [email protected] How I did it Add detach to the choice list. How to verify it Existing unit test. Tested on DUT
EdenGri
pushed a commit
to EdenGri/sonic-utilities
that referenced
this pull request
Oct 12, 2022
What I did Add support for config mux mode detach. Stemming from sonic-net/sonic-linkmgrd#79 sign-off: Jing Zhang [email protected] How I did it Add detach to the choice list. How to verify it Existing unit test. Tested on DUT
mdanish-kh
pushed a commit
to hamnarauf/sonic-utilities
that referenced
this pull request
Oct 22, 2022
What I did Add support for config mux mode detach. Stemming from sonic-net/sonic-linkmgrd#79 sign-off: Jing Zhang [email protected] How I did it Add detach to the choice list. How to verify it Existing unit test. Tested on DUT
yxieca
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Oct 25, 2022
What I did Add support for config mux mode detach. Stemming from sonic-net/sonic-linkmgrd#79 sign-off: Jing Zhang [email protected] How I did it Add detach to the choice list. How to verify it Existing unit test. Tested on DUT
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
What I did Add support for config mux mode detach. Stemming from sonic-net/sonic-linkmgrd#79 sign-off: Jing Zhang [email protected] How I did it Add detach to the choice list. How to verify it Existing unit test. Tested on DUT
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
What I did Add support for config mux mode detach. Stemming from sonic-net/sonic-linkmgrd#79 sign-off: Jing Zhang [email protected] How I did it Add detach to the choice list. How to verify it Existing unit test. Tested on DUT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Make sure self ToR is in
automode before switching peer tostandby. Also add support fordetachmode.detachmode is equal toautomode for SELF, but under this mode, ToR won't touch PEER's status.sign-off: Jing Zhang [email protected]
Type of change
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Documentation