Skip to content

Add interface-id option #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Conversation

kellyyeh
Copy link
Collaborator

@kellyyeh kellyyeh commented Aug 1, 2022

Why I did it

Support interface-id option with opaque value carrying link-address which will be used in dual-tor

How I did it

Add interface-id option in DHCP_RELAY configuration table, copy link-address to interface-id value

@yxieca
Copy link
Contributor

yxieca commented Aug 5, 2022

Is there unit test to cover this change?

Copy link
Collaborator

@saiarcot895 saiarcot895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending unit tests.

@saiarcot895
Copy link
Collaborator

@yxieca the unit test PR (#5) is still open, should we merge that in first, then this?

@kellyyeh
Copy link
Collaborator Author

kellyyeh commented Aug 9, 2022

@yxieca the unit test PR (#5) is still open, should we merge that in first, then this?

Working on cleaning up unittest PR. Will merge unittest first

@yxieca
Copy link
Contributor

yxieca commented Aug 10, 2022

@yxieca the unit test PR (#5) is still open, should we merge that in first, then this?

Working on cleaning up unittest PR. Will merge unittest first

Sure. when will #5 ready for review/merge?

@yxieca yxieca merged commit e2cd585 into sonic-net:master Sep 1, 2022
@kellyyeh kellyyeh deleted the interface-id branch September 1, 2022 00:30
kellyyeh added a commit to kellyyeh/sonic-dhcp-relay that referenced this pull request Oct 8, 2022
* Add interface-id option

* Add out of bound check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants