Skip to content

Add new libswsscommon dependency in lgtm #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Add new libswsscommon dependency in lgtm #11

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610c3e5
Add new libswsscommon dependency
kellyyeh Aug 11, 2022
9a703cc
Update lgtm.yml
kellyyeh Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lgtm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ extraction:
- "libgmock-dev"
- "dh-exec"
- "swig3.0"
- "uuid-dev"
- "libzmq5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this one? libzmq3-dev will bring in libzmq5 automatically, and in case there's some ABI change and the package name changes, it's one less thing to update here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

- "libzmq3-dev"
after_prepare:
- "git clone https://github.com/Azure/sonic-swss-common; pushd sonic-swss-common; ./autogen.sh; fakeroot dpkg-buildpackage -us -uc -b; popd"
- "dpkg-deb -x libswsscommon_1.0.0_amd64.deb $LGTM_WORKSPACE"
Expand Down