[DPB][YANG] Fix cases when boolean is used in different literal cases #9654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@judyjoseph |
* Add boolean as typedef to sonic-types * Fix boolean in sonic-feature yang model * Fix boolean in sonic-flex_counter yang model Signed-off-by: Mykola Gerasymenko <[email protected]>
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@judyjoseph @qiluo-msft Please review. |
qiluo-msft
reviewed
Jan 5, 2022
qiluo-msft
reviewed
Jan 5, 2022
src/sonic-yang-models/tests/yang_model_tests/tests/feature.json
Outdated
Show resolved
Hide resolved
qiluo-msft
approved these changes
Jan 5, 2022
Signed-off-by: Mykola Gerasymenko <[email protected]>
|
@qiluo-msft Please merge. |
qiluo-msft
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Gerasymenko [email protected]
Why I did it
It was request to cherry-pick fix from master (#9418) to 202111 branch to fix issue when boolean is used in different literal cases.
How I did it
Added boolean to sonic-types as typedef with different literal cases.
How to verify it
Run the command config interface breakout <interface_name> <breakout_mode>
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)