[sonic-cfggen]: Add bgp asn for yang validation #9640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gang Lv [email protected]
|
My understanding of currently SONiC behaviors:
So right now, we need to fix sonic-device_metadata.yang to support above behaviors. In future, ideally we need to improve the first 2 cases, let /etc/frr/bgpd.conf handles them gracefully. |
lguohan
reviewed
Jan 5, 2022
| <a:ASN>65100</a:ASN> | ||
| <a:Hostname>linecard-1</a:Hostname> | ||
| <a:Peers> | ||
| <BGPPeer> |
There was a problem hiding this comment.
do you need all these peers or we can just add asn and that is enough?
Signed-off-by: Gang Lv [email protected]
qiluo-msft
approved these changes
Jan 12, 2022
lguohan
approved these changes
Jan 12, 2022
ganglyu
added
the
Request for 202111 Branch
judyjoseph
pushed a commit
that referenced
this pull request
Jan 23, 2022
Why I did it Config db schema generated by minigraph can’t pass yang validation, bgp_asn must not be None. How I did it Update sampe-voq-graph.xml to add bgp_asn. How to verify it Build sonic-config-engine. Run command 'sonic-cfggen -m tests/sample-voq-graph.xml -p tests/voq-sample-port-config.ini --print-data', and check bgp_asn. Signed-off-by: Gang Lv [email protected]
abdosi
added a commit
to abdosi/sonic-buildimage
that referenced
this pull request
Jun 28, 2024
…)" This reverts commit c11ab02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Lv [email protected]
Why I did it
Config db schema generated by minigraph can’t pass yang validation, bgp_asn must not be None.
How I did it
Update sampe-voq-graph.xml to add bgp_asn.
How to verify it
Build sonic-config-engine.
Run command 'sonic-cfggen -m tests/sample-voq-graph.xml -p tests/voq-sample-port-config.ini --print-data', and check bgp_asn.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix #9576
A picture of a cute animal (not mandatory but encouraged)