SONiC CBF MAPs Yang #9116
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "DSCP_TO_FC_MAP_CREATE": { | ||
| "desc": "Configure a DSCP to Forwarding class map." | ||
| }, | ||
| "DSCP_TO_FC_MAP_CREATE_INVALID_DSCP": { | ||
| "desc": "Configure a DSCP to Forwarding class map with invalid key.", | ||
| "eStr": "Invalid DSCP" | ||
|
There was a problem hiding this comment. eStr should match to the error from Libyang. This may not pass. Do you see successful build of PKG. There was a problem hiding this comment. Unless I misunderstood what you meant I think the error strings do match in this case. |
||
| }, | ||
| "DSCP_TO_FC_MAP_CREATE_INVALID_FC": { | ||
| "desc": "Configure a DSCP to Forwarding class map with invalid value.", | ||
| "eStr": "Invalid Forwarding Class" | ||
| }, | ||
| "EXP_TO_FC_MAP_CREATE": { | ||
| "desc": "Configure a EXP to Forwarding class map." | ||
| }, | ||
| "EXP_TO_FC_MAP_CREATE_INVALID_EXP": { | ||
| "desc": "Configure a EXP to Forwarding class map with invalid key.", | ||
| "eStr": "Invalid EXP" | ||
| }, | ||
| "EXP_TO_FC_MAP_CREATE_INVALID_FC": { | ||
| "desc": "Configure a EXP to Forwarding class map with invalid value.", | ||
| "eStr": "Invalid Forwarding Class" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| { | ||
| "DSCP_TO_FC_MAP_CREATE": { | ||
| "sonic-dscp-fc-map:sonic-dscp-fc-map": { | ||
| "sonic-dscp-fc-map:DSCP_TO_FC_MAP": { | ||
| "DSCP_TO_FC_MAP_LIST": [ | ||
| { | ||
| "name": "map1", | ||
| "DSCP_TO_FC_MAP": [ | ||
| { | ||
| "dscp": "1", | ||
| "fc": "1" | ||
| }, | ||
| { | ||
| "dscp":"2", | ||
| "fc":"2" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "map2", | ||
| "DSCP_TO_FC_MAP": [ | ||
| { | ||
| "dscp": "1", | ||
| "fc": "1" | ||
| }, | ||
| { | ||
| "dscp":"2", | ||
| "fc":"2" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| "DSCP_TO_FC_MAP_CREATE_INVALID_DSCP": { | ||
| "sonic-dscp-fc-map:sonic-dscp-fc-map": { | ||
| "sonic-dscp-fc-map:DSCP_TO_FC_MAP": { | ||
| "DSCP_TO_FC_MAP_LIST": [ | ||
| { | ||
| "name": "map3", | ||
| "DSCP_TO_FC_MAP": [ | ||
| { | ||
| "dscp": "64", | ||
| "fc": "1" | ||
| }, | ||
| { | ||
| "dscp":"2", | ||
| "fc":"2" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| "DSCP_TO_FC_MAP_CREATE_INVALID_FC": { | ||
| "sonic-dscp-fc-map:sonic-dscp-fc-map": { | ||
| "sonic-dscp-fc-map:DSCP_TO_FC_MAP": { | ||
| "DSCP_TO_FC_MAP_LIST": [ | ||
| { | ||
| "name": "map3", | ||
| "DSCP_TO_FC_MAP": [ | ||
| { | ||
| "dscp": "1", | ||
| "fc": "8" | ||
| }, | ||
| { | ||
| "dscp":"2", | ||
| "fc":"2" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| "EXP_TO_FC_MAP_CREATE": { | ||
| "sonic-exp-fc-map:sonic-exp-fc-map": { | ||
| "sonic-exp-fc-map:EXP_TO_FC_MAP": { | ||
| "EXP_TO_FC_MAP_LIST": [ | ||
| { | ||
| "name": "map1", | ||
| "EXP_TO_FC_MAP": [ | ||
| { | ||
| "exp": "1", | ||
| "fc": "1" | ||
| }, | ||
| { | ||
| "exp":"2", | ||
| "fc":"2" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "name": "map2", | ||
| "EXP_TO_FC_MAP": [ | ||
| { | ||
| "exp": "1", | ||
| "fc": "1" | ||
| }, | ||
| { | ||
| "exp":"2", | ||
| "fc":"2" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| "EXP_TO_FC_MAP_CREATE_INVALID_EXP": { | ||
| "sonic-exp-fc-map:sonic-exp-fc-map": { | ||
| "sonic-exp-fc-map:EXP_TO_FC_MAP": { | ||
| "EXP_TO_FC_MAP_LIST": [ | ||
| { | ||
| "name": "map3", | ||
| "EXP_TO_FC_MAP": [ | ||
| { | ||
| "exp": "8", | ||
| "fc": "1" | ||
| }, | ||
| { | ||
| "exp":"2", | ||
| "fc":"2" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| "EXP_TO_FC_MAP_CREATE_INVALID_FC": { | ||
| "sonic-exp-fc-map:sonic-exp-fc-map": { | ||
| "sonic-exp-fc-map:EXP_TO_FC_MAP": { | ||
| "EXP_TO_FC_MAP_LIST": [ | ||
| { | ||
| "name": "map3", | ||
| "EXP_TO_FC_MAP": [ | ||
| { | ||
| "exp": "1", | ||
| "fc": "8" | ||
| }, | ||
| { | ||
| "exp":"2", | ||
| "fc":"2" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| module sonic-dscp-fc-map { | ||
|
|
||
| yang-version 1.1; | ||
|
|
||
| namespace "http://github.com/Azure/sonic-dscp-fc-map"; | ||
|
|
||
| prefix dtm; | ||
|
|
||
| organization | ||
| "SONiC"; | ||
|
|
||
| contact | ||
| "SONiC"; | ||
|
|
||
| description | ||
| "DSCP_TO_FC_MAP yang Module for SONiC OS"; | ||
|
|
||
| revision 2021-10-29 { | ||
| description | ||
| "Initial revision."; | ||
| } | ||
|
|
||
| container sonic-dscp-fc-map { | ||
|
There was a problem hiding this comment. I am not reviewing YANG models, since I am not SME for this. Thx There was a problem hiding this comment. I will reviews, thanks for reviewing the rest. There was a problem hiding this comment. @smaheshm since Praveen has approved the other changes is this PR ready to be merged in? |
||
|
|
||
| container DSCP_TO_FC_MAP { | ||
|
|
||
| description "DSCP_TO_FC_MAP part of config_db.json"; | ||
|
|
||
| list DSCP_TO_FC_MAP_LIST { | ||
|
|
||
| key "name"; | ||
|
|
||
| leaf name { | ||
| type string { | ||
| pattern '[a-zA-Z0-9]{1}([-a-zA-Z0-9_]{0,31})'; | ||
| length 1..32 { | ||
| error-message "Invalid length for map name."; | ||
| error-app-tag map-name-invalid-length; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| list DSCP_TO_FC_MAP { //this is list inside list for storing mapping between two fields | ||
|
|
||
| key "dscp"; | ||
|
|
||
| leaf dscp { | ||
| type string { | ||
| pattern "6[0-3]|[1-5][0-9]?|[0-9]?" { | ||
| error-message "Invalid DSCP"; | ||
| error-app-tag dscp-invalid; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| leaf fc { | ||
| type string { | ||
| pattern "[0-7]?" { | ||
| error-message "Invalid Forwarding Class"; | ||
| error-app-tag fc-invalid; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This for translation for a specific type, so let`s mark it as Type_1_list_maps_model. Add all lists in it.