Skip to content

[Mellanox] [202106] Fix issue: PSU model/serial/revision info should be updated after replacing PSU #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Oct 22, 2021

Why I did it

This is for 202106 only as there is a big PR #8422 in master which might not be cherry-picked to 202106.

Fix issue:

  1. If PSU is missing, error log is printed like "Fail to read PSU1 serial number: No key SN_VPD_FIELD in VPD /var/run/hw-management/eeprom/psu1_vpd"
  2. If PSU is replacing by a new one, the model/serial/revision info cannot be updated without a reboot/config reload.

How I did it

  1. If VPD file does not exist, don't print error log
  2. Update model/serial/revision info if VPD file is modified

How to verify it

Manual test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft October 22, 2021 01:32
@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review October 22, 2021 01:37
@prgeor prgeor merged commit 48d412d into sonic-net:202106 Nov 1, 2021
nhe-NV added a commit to nhe-NV/sonic-mgmt that referenced this pull request Nov 10, 2021
The code added in sonic-net/sonic-buildimage#9040 will introduce timing err msg, the test case need to be aligned with adding ingnore for  the err msg since it is a functinal issue.
kevinskwang pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Nov 15, 2021
…4659)

The code added in sonic-net/sonic-buildimage#9040 will introduce timing err msg, the test case need to be aligned with adding ingnore for  the err msg since it is a functinal issue.
AntonHryshchuk pushed a commit to AntonHryshchuk/sonic-mgmt that referenced this pull request Jan 4, 2022
…onic-net#4659)

The code added in sonic-net/sonic-buildimage#9040 will introduce timing err msg, the test case need to be aligned with adding ingnore for  the err msg since it is a functinal issue.
@Junchao-Mellanox Junchao-Mellanox deleted the vpd_parser branch June 12, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants