Skip to content

[chassis][mgmtif][defaultroute] Fix for issue of mgmt if default route #8989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vganesan-nokia
Copy link
Contributor

Why I did it

If management interface is configured in config db, a default route is added with the management interface (eth0) as the gateway with same admin distance as iBGP routes. This is done as a backup reachability for management interface. In chassis using multi-asic image, this route was interfering with the default routes received from the iBGP sessions since static route has higher preference (i.e., the route on eth0 is selected as best route). However since routesync does not send any route on eth0 to orchagent, we do not have a default route in the datapath. This PR fixes this issue

How I did it

The backup default route management interface as gateway is added as part of staticd configuration in FRR. This is changed to set the administrative distance greater than the administrative distance of iBGP routes.

How to verify it

  • In multi-asic imaged chassis (especially with line card with single asics), configure eth0 management interface in MGMT_INTERFACE table.
  • Configure a default route with gateway on an eBGP interface. This default route from eBGP sessions will be leaned internally via iBGP in all other asics (via backend asics' iBGP sessions)
  • Bring up the chassis and make sure the bgp is up and running and all iBGP and eBGP sessions are up.
  • Check the route table for 0.0.0.0/0 route.
  • Observe that the there is a route for 0.0.0.0/0 with gateway equal to the management interface address and this route is not the best route.

Description for the changelog

Fix for issue of static default route on management interface interfering with default routes learned via iBGP.

The issue of default route on mgmt interface messing up with the default
route learned via iBGP is fixed. This fix is to increase the
administrative distance (preference) of defalut route added with
management interface as the gateway. The change is done while adding
this static route as part of staticd configuration in FRR.

Signed-off-by: vedganes <[email protected]>
@vganesan-nokia vganesan-nokia force-pushed the multiasic-defroute-fix1 branch from f81bf61 to 98ce5a6 Compare October 18, 2021 18:25
@abdosi
Copy link
Contributor

abdosi commented Oct 19, 2021

@arlakshm please check

Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arlakshm arlakshm requested a review from prsunny October 25, 2021 22:31
@arlakshm arlakshm linked an issue Oct 25, 2021 that may be closed by this pull request
@rlhui rlhui added the Chassis 🤖 Modular chassis support label Oct 31, 2021
@vganesan-nokia
Copy link
Contributor Author

With PR #9182, since the static default route addition on mgmt interface is removed, this PR is no longer needed. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chassis 🤖 Modular chassis support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chassis] Default route learnt from peer linecard is not installed
4 participants