Skip to content

[docker-ptf] Upgrade to buster #8254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

msosyak
Copy link
Contributor

@msosyak msosyak commented Jul 23, 2021

Why I did it

To make docker ptf buster based

How I did it

Update docker file

How to verify it

make init
make configure PLATFORM=vs
make target/docker-ptf.gz

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@msosyak msosyak requested a review from lguohan as a code owner July 23, 2021 10:32
@lguohan lguohan requested a review from yxieca July 23, 2021 16:10
@yxieca
Copy link
Contributor

yxieca commented Jul 26, 2021

@msosyak did you run sonic-mgmt test suite with a new PTF docker based off buster?

Can you clarify the intention of upgrading ptf to buster base?

@msosyak
Copy link
Contributor Author

msosyak commented Jul 29, 2021

Yes. I have run sanity regression with few tests from t1 and t0 and all passed as expected.

My intention is to align all docker bases to avoid building a stretch slave image.

@msosyak
Copy link
Contributor Author

msosyak commented Aug 2, 2021

@yxieca Do you see any issues with that update or could we merge this PR?

@yxieca
Copy link
Contributor

yxieca commented Aug 2, 2021

@msosyak , do you have the capability of running a full nightly test with buster ptf and compare the results with stretch ptf? If the test results are the same, then we can proceed with this upgrade.

@msosyak
Copy link
Contributor Author

msosyak commented Aug 11, 2021

@yxieca Apologies for the late response. I was in PTO. Yes, I have run the regression and the result for the docker-ptf buster is the same as for the docker-ptf stretch.

@msosyak
Copy link
Contributor Author

msosyak commented Aug 13, 2021

Could we marge this or something else is needed?

@msosyak
Copy link
Contributor Author

msosyak commented Aug 18, 2021

@yxieca Please update

@yxieca yxieca merged commit 4d03526 into sonic-net:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants