[platform] Add new platform as4630-54npe #8220

seanwu-ec · 2021-07-19T09:04:14Z

Why I did it

To support Accton's new model: AS4630-54NPE

How I did it

Part of this PR is restored from PR#6189. And the rest of the code is basically identical to AS4630-54PE's.

How to verify it

Built the image and tested it on DUT. The tests include some functional checks and going through some commands on the show program.

Which release branch to backport (provide reason below if selected)

Description for the changelog

[Accton] add new platform AS4630-54NPE

A picture of a cute animal (not mandatory but encouraged)

lgtm-com · 2021-07-19T09:31:41Z

This pull request introduces 61 alerts when merging 6c69d45 into c89b62e - view on LGTM.com

new alerts:

41 for Unused import
8 for Unused local variable
6 for Use of 'global' at module level
2 for Unreachable code
2 for Variable defined multiple times
1 for Except block handles 'BaseException'
1 for Duplicate key in dict literal

lgtm-com · 2021-07-22T07:23:05Z

This pull request introduces 1 alert when merging 46b8e49 into c31c869 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2021-07-23T13:34:04Z

This pull request introduces 1 alert when merging daebd20 into 7698747 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

seanwu-ec · 2021-07-26T00:45:34Z

This pull request introduces 1 alert when merging daebd20 into 7698747 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

I don't know how come LGTM has this alert. namedtuple DOES have 'defaults' argument, and it works.

lgtm-com · 2021-07-26T02:54:38Z

This pull request introduces 1 alert when merging 4034b4c into 5e435e0 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

seanwu-ec · 2021-07-26T08:09:37Z

/azpw run

mssonicbld · 2021-07-26T08:09:38Z

/AzurePipelines run

azure-pipelines · 2021-07-26T08:09:57Z

Azure Pipelines successfully started running 1 pipeline(s).

lgtm-com · 2021-08-02T06:25:49Z

This pull request introduces 1 alert when merging 8cec9bc into 5259af2 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

seanwu-ec · 2021-09-22T07:22:58Z

Hi @lguohan , hi @jleveque , would you mind give me a hint about how to get my PRs reviewed and merged? Anything would do. Thanks.

lgtm-com · 2021-10-13T03:53:44Z

This pull request introduces 1 alert when merging e067483 into e8adee2 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

lgtm-com · 2021-12-13T06:45:40Z

This pull request introduces 1 alert when merging 84227ae into 6402a02 - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

seanwu-ec · 2021-12-28T05:56:34Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2021-12-28T05:56:35Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-12-28T05:56:47Z

Azure Pipelines successfully started running 1 pipeline(s).

lgtm-com · 2022-01-18T09:00:36Z

This pull request introduces 1 alert when merging dee8c3721283668fb512971be53f3ae1299b6a96 into c80dabd - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

prgeor · 2022-01-18T10:57:55Z

This pull request introduces 1 alert when merging dee8c37 into c80dabd - view on LGTM.com

new alerts:

1 for Wrong name for an argument in a call

@seanwu-ec new LGTM warnings

seanwu-ec · 2022-01-19T01:20:27Z

This pull request introduces 1 alert when merging dee8c37 into c80dabd - view on LGTM.com
new alerts:

1 for Wrong name for an argument in a call

@seanwu-ec new LGTM warnings

Hi @prgeor,
Thanks for your review.
As I commented above, I don't know how come LGTM has this alert.
namedtuple DOES have 'defaults' argument, and it works. The same goes for Python3.9.

Plz check:
https://docs.python.org/3.7/library/collections.html#collections.namedtuple
https://github.com/python/cpython/blob/041bfafeb00b0e5e565986b01c00bf9cddce3b4c/Lib/collections/__init__.py#L316
Thanks.

seanwu-ec · 2022-01-19T08:39:31Z

Hi @prgeor,
You just remind me that Accton has decided to keep that 6-levels thermal threshold APIs ONLY to Accton's customized SONiC instead of messing up community SONiC code. I've removed the use of namedtuple there and the corresponding LGTM alert is gone. Thanks.

prgeor · 2022-01-24T06:26:52Z

/azp run

Signed-off-by: Sean Wu <[email protected]>

- This reverts commit 9da4c9e. - We still need these scripts for some utils on 202012br, such likes decode-syseeprom.

- fix python2-styled print - fix illegal use of chr() - remove assigning no_buffer while open sysfs node. Signed-off-by: Sean Wu <[email protected]>

* correct the wait and timeout mechanism for better CPU usage. * Fix is_host() API might make OS stuck Signed-off-by: Sean Wu <[email protected]>

Signed-off-by: Sean Wu <[email protected]>

* This reverts commit daebd20. This reverts commit 84227ae. * Accton came to a conclusion that only keeps 6-levels thresholds APIs to Accton's customized SONiC instead of messing up the community SONiC code. Signed-off-by: Sean Wu <[email protected]>

* This solve flooding DMAR err msg: "handling fault status reg 2" Signed-off-by: Sean Wu <[email protected]>

seanwu-ec · 2023-05-16T09:49:59Z

Close this due to there is a new one for the latest master code-base.
#14293

seanwu-ec marked this pull request as ready for review July 26, 2021 08:08

seanwu-ec requested review from jleveque and lguohan as code owners July 26, 2021 08:08

seanwu-ec mentioned this pull request Dec 28, 2021

Test PR, no need to review, thx #9652

Draft

5 tasks

seanwu-ec requested review from prgeor, sujinmkang and vdahiya12 as code owners January 18, 2022 08:37

prgeor self-assigned this Jan 18, 2022

seanwu-ec marked this pull request as draft January 19, 2022 02:04

seanwu-ec marked this pull request as ready for review January 19, 2022 08:35

seanwu-ec and others added 26 commits May 5, 2022 15:54

[AS4630-54NPE] Enable thermalctld, disable pcied

5a20d29

Signed-off-by: Sean Wu <[email protected]>

Fix LGTM alerts

1dc2874

Signed-off-by: Sean Wu <[email protected]>

Migrate API2.0 from AS4630-54PE to AS4630-54NPE

e843b6d

Signed-off-by: Sean Wu <[email protected]>

Remove redundancy in accton_as4630_54npe_util.py

31c2d6b

Signed-off-by: Sean Wu <[email protected]>

Apply changes from PR#5297

0143ef5

Signed-off-by: Sean Wu <[email protected]>

Apply changes from PR#6035

6289f88

Signed-off-by: Sean Wu <[email protected]>

Apply changes from PR#8033

0aa720a

Signed-off-by: Sean Wu <[email protected]>

Fix LGTM alerts

66ab7e2

Signed-off-by: Sean Wu <[email protected]>

Fix missing sonic_platform whl pkg

2089895

Signed-off-by: Sean Wu <[email protected]>

Make scripts executable

bdbee1a

Signed-off-by: Sean Wu <[email protected]>

Fix python2-style print in util.py

bc1ce6f

Signed-off-by: Sean Wu <[email protected]>

Remove API 1.0 util python scripts

ccd1172

Signed-off-by: Sean Wu <[email protected]>

Make sonic_platform package installed while bootup

8a95c3e

Signed-off-by: Sean Wu <[email protected]>

Fix PSU model/serial num fetching

d2cdb8e

Signed-off-by: Sean Wu <[email protected]>

Implement thermal threshold APIs

ddd7ec9

Signed-off-by: Sean Wu <[email protected]>

Revert "Remove API 1.0 util python scripts"

d553845

- This reverts commit 9da4c9e. - We still need these scripts for some utils on 202012br, such likes decode-syseeprom.

[as4630-54npe] fix errors in sfputil.py

593159f

- fix python2-styled print - fix illegal use of chr() - remove assigning no_buffer while open sysfs node. Signed-off-by: Sean Wu <[email protected]>

Fix as4630-54npe xcvrd busy issue

97754e2

* correct the wait and timeout mechanism for better CPU usage. * Fix is_host() API might make OS stuck Signed-off-by: Sean Wu <[email protected]>

Add platform_asic file because PR#8542

cbaf3dd

Signed-off-by: Sean Wu <[email protected]>

[4630-54NPE] Add CPU coretemp to thermal.py

3a344b9

Signed-off-by: Sean Wu <[email protected]>

Fix kernel5.10 build err in cpld drv

e5bd138

Signed-off-by: Sean Wu <[email protected]>

Enable pca954x idle_disconnect

1ed40b0

Signed-off-by: Sean Wu <[email protected]>

Add intel_iommu=off to installer.conf

12e51d3

* This solve flooding DMAR err msg: "handling fault status reg 2" Signed-off-by: Sean Wu <[email protected]>

Update port_config.ini on as4630-54npe

dedacc2

Add psu_index into thermal_list.

d06be47

ec-michael-shih force-pushed the add_as4630-54npe_api2 branch from 0832308 to d06be47 Compare May 5, 2022 08:05

seanwu-ec requested a review from a team as a code owner June 10, 2022 02:01

seanwu-ec closed this May 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[platform] Add new platform as4630-54npe #8220

[platform] Add new platform as4630-54npe #8220

seanwu-ec commented Jul 19, 2021 •

edited

Loading

lgtm-com bot commented Jul 19, 2021

lgtm-com bot commented Jul 22, 2021

lgtm-com bot commented Jul 23, 2021

seanwu-ec commented Jul 26, 2021

lgtm-com bot commented Jul 26, 2021

seanwu-ec commented Jul 26, 2021

mssonicbld commented Jul 26, 2021

azure-pipelines bot commented Jul 26, 2021

lgtm-com bot commented Aug 2, 2021

seanwu-ec commented Sep 22, 2021

lgtm-com bot commented Oct 13, 2021

lgtm-com bot commented Dec 13, 2021

seanwu-ec commented Dec 28, 2021

mssonicbld commented Dec 28, 2021

azure-pipelines bot commented Dec 28, 2021

lgtm-com bot commented Jan 18, 2022

prgeor commented Jan 18, 2022

seanwu-ec commented Jan 19, 2022

seanwu-ec commented Jan 19, 2022

prgeor commented Jan 24, 2022

seanwu-ec commented May 16, 2023

[platform] Add new platform as4630-54npe #8220

[platform] Add new platform as4630-54npe #8220

Conversation

seanwu-ec commented Jul 19, 2021 • edited Loading

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

lgtm-com bot commented Jul 19, 2021

lgtm-com bot commented Jul 22, 2021

lgtm-com bot commented Jul 23, 2021

seanwu-ec commented Jul 26, 2021

lgtm-com bot commented Jul 26, 2021

seanwu-ec commented Jul 26, 2021

mssonicbld commented Jul 26, 2021

azure-pipelines bot commented Jul 26, 2021

lgtm-com bot commented Aug 2, 2021

seanwu-ec commented Sep 22, 2021

lgtm-com bot commented Oct 13, 2021

lgtm-com bot commented Dec 13, 2021

seanwu-ec commented Dec 28, 2021

mssonicbld commented Dec 28, 2021

azure-pipelines bot commented Dec 28, 2021

lgtm-com bot commented Jan 18, 2022

prgeor commented Jan 18, 2022

seanwu-ec commented Jan 19, 2022

seanwu-ec commented Jan 19, 2022

prgeor commented Jan 24, 2022

seanwu-ec commented May 16, 2023

seanwu-ec commented Jul 19, 2021 •

edited

Loading