[minigraph] Update parsing logic for Storage backend devices #7944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
yxieca
approved these changes
Jun 23, 2021
prsunny
approved these changes
Jun 25, 2021
|
@neethajohn This PR could not be cleanly cherry-pick to 202012. Please submit another PR. |
4 tasks
4 tasks
lolyu
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jul 11, 2021
Approach What is the motivation for this PR? If the device is a storage backend devices(bt0 or bt1), let minigraph_facts return minigraph_vlan_sub_interfaces. Signed-off-by: Longxiang Lyu [email protected] How did you do it? Update minigraph_facts.py based on the logic of sonic-net/sonic-buildimage#7944 return minigraph_vlan_sub_interfaces if it is a storage backend devices. return minigraph_device_metadata to keep device related metadata including resource_type and device_type How did you verify/test it? run minigraph_facts
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 16, 2021
…#8004) Backport #7944 #### Why I did it The current logic generates 'VLAN_SUB_INTERFACE' table if the device type is backend and cluster name contains 'str'. This is not a reliable method to determine a storage backend device #### How I did it Updated the logic to generate 'VLAN_SUB_INTERFACE' table if any of the following conditions hold true 1. device is of type backend and ResourceType attribute is None 2. device is of type backend and ResourceType attribute contains "Storage" 3. device is of type backend and graph contains "Subinterface" section Also updated the logic to set "is_storage_device" to True 1. for Backend, if any of the above conditions hold true 2. for Frontend, if ResourceType attribute contains "Storage" #### How to verify it Added new tests to verify the code changes and built sonic_config_engine-1.0-py3-none-any.whl successfully
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…et#7944) Signed-off-by: Neetha John <[email protected]> Why I did it The current logic generates 'VLAN_SUB_INTERFACE' table if the device type is backend and cluster name contains 'str'. This is not a reliable method to determine a storage backend device How I did it Updated the logic to generate 'VLAN_SUB_INTERFACE' table if any of the following conditions hold true - device is of type backend and ResourceType attribute is None - device is of type backend and ResourceType attribute contains "Storage" - device is of type backend and graph contains "Subinterface" section Also updated the logic to set "is_storage_device" to True - For Backend, if any of the above conditions hold true - For Frontend, if ResourceType attribute contains "Storage" How to verify it Added new tests to verify the code changes and built sonic_config_engine-1.0-py3-none-any.whl successfully
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Approach What is the motivation for this PR? If the device is a storage backend devices(bt0 or bt1), let minigraph_facts return minigraph_vlan_sub_interfaces. Signed-off-by: Longxiang Lyu [email protected] How did you do it? Update minigraph_facts.py based on the logic of sonic-net/sonic-buildimage#7944 return minigraph_vlan_sub_interfaces if it is a storage backend devices. return minigraph_device_metadata to keep device related metadata including resource_type and device_type How did you verify/test it? run minigraph_facts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The current logic generates 'VLAN_SUB_INTERFACE' table if the device type is backend and cluster name contains 'str'. This is not a reliable method to determine a storage backend device
How I did it
Updated the logic to generate 'VLAN_SUB_INTERFACE' table if any of the following conditions hold true
Also updated the logic to set "is_storage_device" to True
How to verify it
Added new tests to verify the code changes and built sonic_config_engine-1.0-py3-none-any.whl successfully
Which release branch to backport (provide reason below if selected)
Description for the changelog