Skip to content

[Mellanox] Read EEPROM data from DB if possible #7808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Jun 7, 2021

Depends on sonic-net/sonic-platform-common#193

Why I did it

Remove EEPROM cache file and use DB instead

How I did it

  1. Read EEPROM data from DB if possible
  2. If data is not ready in DB, read from hardware using a visitor pattern

How to verify it

Manual test and regression

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox Junchao-Mellanox requested a review from lguohan as a code owner June 7, 2021 05:55
@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2021

This pull request introduces 1 alert and fixes 4 when merging ba8e9d0 into b2a2cf0 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

fixed alerts:

  • 4 for Except block handles 'BaseException'

@keboliu keboliu requested a review from jleveque June 7, 2021 07:06
@Junchao-Mellanox
Copy link
Collaborator Author

PR for updating submodule pointer: #7868

@liat-grozovik liat-grozovik merged commit f294096 into sonic-net:master Jun 20, 2021
@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Jun 21, 2021

This commit could not be cleanly cherry-pick to 202012. Please submit another PR

@Junchao-Mellanox Junchao-Mellanox deleted the read-eeprom-from-db branch June 21, 2021 10:14
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
- Why I did it
Remove EEPROM cache file and use DB instead

- How I did it
Read EEPROM data from DB if possible
If data is not ready in DB, read from hardware using a visitor pattern

- How to verify it
Manual test and regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants