add config-setup.service as dependency for pcie-check.service #7599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sujinmkang: In the "Why I did it" section, can you please state the reason why the dependency is needed? |
jleveque
approved these changes
May 18, 2021
|
@jleveque can you please cherry-pick this change to 202012 also? |
qiluo-msft
pushed a commit
that referenced
this pull request
May 19, 2021
Why I did it start pcie-check.service after config-setup.service since pcie_util depends on device_info which is available with config db metadata. How I did it Add config-setup.service as a dependency of pcie-check.service How to verify it Upon reboot, check if the pcie-check.sh throws the platform api error which is dependent on DEVICE_METADATA
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…net#7599) Why I did it start pcie-check.service after config-setup.service since pcie_util depends on device_info which is available with config db metadata. How I did it Add config-setup.service as a dependency of pcie-check.service How to verify it Upon reboot, check if the pcie-check.sh throws the platform api error which is dependent on DEVICE_METADATA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
start pcie-check.service after config-setup.service since pcie_util depends on device_info which is available with config db metadata.
How I did it
Add config-setup.service as a dependency of pcie-check.service
How to verify it
Upon reboot, check if the pcie-check.sh throws the platform api error which is dependent on DEVICE_METADATA
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)