Skip to content

[device/celestica]: Fix failed test cases of Haliburton platform API #7579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2021

Conversation

mudsut4ke
Copy link
Contributor

- Why I did it

  • To fix failed test cases of Haliburton platform APIs that found on platform_tests script

- How I did it

  1. Add device/celestica/x86_64-cel_e1031-r0/platform.json
  2. Update functions to support python3.7
  3. Add more functions follow latest sonic_platform_base
  4. Fix the bug

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Signed-off-by: Wirut Getbamrung [[email protected]]

…#253)

* [platform/cel]: add psu eeprom driver

* [device/celestica]: fix failed test cases of platform apis

* [device/celestica]: Fixed failed cases of psu ant wdt apis
@lgtm-com
Copy link

lgtm-com bot commented May 11, 2021

This pull request introduces 4 alerts when merging a10477d into 3dc879b - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 12, 2021

This pull request introduces 1 alert when merging dd75f5b into a070f1a - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@mudsut4ke mudsut4ke marked this pull request as ready for review May 17, 2021 04:34
* [device/celestica]: fix sfputil

* [device/celestica]: fix firmware util
@mudsut4ke
Copy link
Contributor Author

@jleveque , Can you please review and merge this PR ?
But before that please help cherry-pick #6493 to 202012 branch first to avoid conflict on 202012

@yxieca yxieca requested a review from sujinmkang July 16, 2021 03:51
@yxieca
Copy link
Contributor

yxieca commented Jul 16, 2021

@sujinmkang please review this PR.

@yxieca
Copy link
Contributor

yxieca commented Jul 16, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca
Copy link
Contributor

yxieca commented Jul 16, 2021

@mudsut4ke please create an PR for 202012 branch. This change will break 202012 build due to platform.json format differences.

@mudsut4ke
Copy link
Contributor Author

@mudsut4ke please create an PR for 202012 branch. This change will break 202012 build due to platform.json format differences.

@yxieca ,In this PR #8217, I have cherry-picked a change from #6493 to the 202012 branch
Please help to review and merge

@sujinmkang sujinmkang merged commit 4bf873b into sonic-net:master Jul 23, 2021
mudsut4ke pushed a commit to mudsut4ke/sonic-buildimage that referenced this pull request Jul 30, 2021
…onic-net#7579)

- Why I did it
To fix failed test cases of Haliburton platform APIs that found on platform_tests script
- How I did it
Add device/celestica/x86_64-cel_e1031-r0/platform.json
Update functions to support python3.7
Add more functions follow latest sonic_platform_base
Fix the bug
- How to verify it
Run platform_tests script

Signed-off-by: Wirut Getbamrung [[email protected]]
judyjoseph pushed a commit that referenced this pull request Aug 7, 2021
…7579)

- Why I did it
To fix failed test cases of Haliburton platform APIs that found on platform_tests script
- How I did it
Add device/celestica/x86_64-cel_e1031-r0/platform.json
Update functions to support python3.7
Add more functions follow latest sonic_platform_base
Fix the bug
- How to verify it
Run platform_tests script

Signed-off-by: Wirut Getbamrung [[email protected]]
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…onic-net#7579)

- Why I did it
To fix failed test cases of Haliburton platform APIs that found on platform_tests script
- How I did it
Add device/celestica/x86_64-cel_e1031-r0/platform.json
Update functions to support python3.7
Add more functions follow latest sonic_platform_base
Fix the bug
- How to verify it
Run platform_tests script

Signed-off-by: Wirut Getbamrung [[email protected]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants