Skip to content

[device/celestica]: Add xcvrd event support for Haliburton #6517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 8, 2021

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Jan 21, 2021

- Why I did it

  • The xcvrd service requires an event detection function, unplug or plug in the transceiver.

- How I did it

  • Add sysfs interrupt to notify userspace app of external interrupt
  • Implement get_change_event() in chassis api.
  • Also begin installing Python 3 sonic-platform package for Celestica platforms

- How to verify it

  • Verify xcvrd running with error in syslog
  • Verify port status and port information with this following command
    • show interfaces status
    • show interfaces transceiver eeprom
  • Log :

Signed-off-by: Wirut Getbamrung [[email protected]]

@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2021

This pull request introduces 6 alerts and fixes 5 when merging 9873730 into cad2025 - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'

fixed alerts:

  • 5 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request fixes 5 alerts when merging 3ecdfce into 6957e37 - view on LGTM.com

fixed alerts:

  • 5 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2021

This pull request introduces 1 alert and fixes 6 when merging 83cc619 into 98298f7 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Feb 1, 2021

This pull request introduces 1 alert and fixes 6 when merging c1671be into 8a024f0 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

fixed alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 1 for Unused import

@mudsut4ke mudsut4ke marked this pull request as ready for review February 9, 2021 06:48
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix LTGM warning: get_serial() method is defined twice in chassis.py

@lgtm-com
Copy link

lgtm-com bot commented Feb 23, 2021

This pull request fixes 6 alerts when merging 2c67713 into f77157f - view on LGTM.com

fixed alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 1 for Unused import

@jleveque
Copy link
Contributor

jleveque commented Mar 5, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2021

This pull request fixes 6 alerts when merging c4626a8 into bb03e5b - view on LGTM.com

fixed alerts:

  • 5 for Wrong number of arguments in a class instantiation
  • 1 for Unused import

@jleveque jleveque merged commit 6ae2cb5 into sonic-net:master Mar 8, 2021
lguohan pushed a commit that referenced this pull request Mar 10, 2021
#### Why I did it
- The xcvrd service requires an event detection function, unplug or plug in the transceiver.

#### How I did it
- Add sysfs interrupt to notify userspace app of external interrupt
- Implement get_change_event() in chassis api.
- Also begin installing Python 3 sonic-platform package for Celestica platforms
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…#6517)

#### Why I did it
- The xcvrd service requires an event detection function, unplug or plug in the transceiver.

#### How I did it
- Add sysfs interrupt to notify userspace app of external interrupt
- Implement get_change_event() in chassis api.
- Also begin installing Python 3 sonic-platform package for Celestica platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants