Skip to content

[submodule] [201911] Update sonic-swss and sonic-sairedis pointers #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

volodymyrsamotiy
Copy link
Collaborator

@volodymyrsamotiy volodymyrsamotiy commented Jan 14, 2021

Signed-off-by: Volodymyr Samotiy [email protected]

- Why I did it
To add updated PFC storm detection logic for Mellanox platforms

- How I did it
Updated sonic-swss and sonic-sairedis submodules' pointers

sonic-swss commits

sonic-sairedis commits:

- How to verify it
Run all PFCWD tests from https://github.com/Azure/sonic-mgmt/tree/master/tests/pfcwd and verified all passed.
Manual test: manually start storm on fanout and manually put port down on fanout few times. Verified that no storm was detected when link was down

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

[submodule] Update sonic-swss and sonic-sairedis pointers

* 4db8328 [pfcwd] Update PFC storm detection logic for Mellanox platforms (sonic-net#1587)

Signed-off-by: Volodymyr Samotiy <[email protected]>
@neethajohn neethajohn changed the title [submodule] Update sonic-swss pointer [submodule] [201911] Update sonic-swss pointer Jan 14, 2021
@neethajohn neethajohn requested a review from abdosi January 15, 2021 18:37
@abdosi
Copy link
Contributor

abdosi commented Jan 15, 2021

retest this please

@liat-grozovik
Copy link
Collaborator

retest vsimage please

@liat-grozovik
Copy link
Collaborator

retest broadcom please

@neethajohn
Copy link
Contributor

@volodymyrsamotiy, can you look into the build failures and fix them?

@volodymyrsamotiy
Copy link
Collaborator Author

@volodymyrsamotiy, can you look into the build failures and fix them?

Sure, checking

@abdosi
Copy link
Contributor

abdosi commented Jan 22, 2021

@volodymyrsamotiy, can you look into the build failures and fix them?

Sure, checking

@volodymyrsamotiy Any update ?

@rlhui
Copy link
Contributor

rlhui commented Jan 26, 2021

retest vsimage please

@rlhui
Copy link
Contributor

rlhui commented Jan 26, 2021

retest broadcom please

@volodymyrsamotiy
Copy link
Collaborator Author

volodymyrsamotiy commented Jan 26, 2021

There is SAI submodule update missing.
I created PR, could you please merge it first (there is just one commit)?:
sonic-net/sonic-sairedis#778
And once done I will update current PR with the changes to advance sairedis submodule as well.

@rlhui
Copy link
Contributor

rlhui commented Jan 26, 2021

There is SAI submodule update missing.
I created PR, could you please merge it first (there is just one commit)?:
Azure/sonic-sairedis#778
And once done I will update current PR with the changes to advance sairedis submodule as well.

It is merged.

* 5b1fb5c [SAI] Update SAI API submodule pointer (sonic-net#778)
* f0f5854 sairedis record file handling (sonic-net#758)

Signed-off-by: Volodymyr Samotiy <[email protected]>
@volodymyrsamotiy volodymyrsamotiy changed the title [submodule] [201911] Update sonic-swss pointer [submodule] [201911] Update sonic-swss and sonic-sairedis pointers Jan 26, 2021
@neethajohn
Copy link
Contributor

@abdosi, can you take a look once again? there is sairedis submodule update as well

@abdosi
Copy link
Contributor

abdosi commented Jan 27, 2021

@volodymyrsamotiy Broadcom build is still failing.

@abdosi
Copy link
Contributor

abdosi commented Jan 27, 2021

/Azurepipelines

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@abdosi
Copy link
Contributor

abdosi commented Jan 27, 2021

Updated the submodule Manually. Closing the PR

@abdosi abdosi closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants