[barefoot] Fix y_profile_set to not reset link #6238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msosyak
changed the title
akokhan
approved these changes
Dec 17, 2020
|
retest vsimage please |
|
retest mellanox please |
|
@lguohan merge this, please |
|
can you explain y profile? |
Y* profile is the name pattern for p4 programs that developed for the current platform. The difference between them is features enabled and resource reservation. |
|
@lguohan could we merge this? |
lguohan
approved these changes
Dec 24, 2020
msosyak
added a commit
to msosyak/sonic-buildimage
that referenced
this pull request
Dec 28, 2020
Y* profile is the name pattern for p4 programs that developed for the current platform. The difference between them is features enabled and resource reservation. For this platform, it is expected to work on any Y profile. but after the latest changes, the first Y profile is always used.
msosyak
added a commit
to msosyak/sonic-buildimage
that referenced
this pull request
Mar 29, 2022
Y* profile is the name pattern for p4 programs that developed for the current platform. The difference between them is features enabled and resource reservation. For this platform, it is expected to work on any Y profile. but after the latest changes, the first Y profile is always used. Signed-off-by: Myron Sosyak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this platform, it is expected to work on any Y profile. but after the latest changes, the first Y profile is always used.
- Why I did it
To be able to set another Y profile
- How I did it
Extend logic to check if the Y profile is already used
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)