Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of hardcore.
Signed-off-by: Garrick He [email protected]
- Why I did it
Even though we bumped the hsflowd version in sflow.mk, the new version is not picked up in the hsflowd Makefile because it is hardcoded. So the lastest images are still using the old version of hsflowd.
- How I did it
Updated the Makefile to use variables instead of hardcore the version.
- How to verify it
Rebuild sflow container and verify hsflowd version with (
hsflowd -v
) to ensure it is 2.0.28- Which release branch to backport (provide reason below if selected)
N/A
- Description for the changelog
instead of hardcore.