Skip to content

[System logs]: Fix logrotate bugs #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2017
Merged

[System logs]: Fix logrotate bugs #535

merged 3 commits into from
Apr 25, 2017

Conversation

jleveque
Copy link
Contributor

  • rsyslog logs were being rotated regardless of whether they exceeded their maixmum size. This was due to "-f" flag passed to logrotate in cron job.

  • After rotation, /var/log/syslog was never written to again. Instead, logs were written to /var/log/syslog.1. This was due to rsyslog not properly closing the file descriptor to the pre-rotated log.

  • Also addresses issue systemd-journald[224]: [/etc/systemd/journald.conf:21] Failed to parse size value, ignoring:  #528

  • Also brought back time-related rotation via the new(er) maxsize option, which performs a boolean OR operation. If the log exceeds the maxsize OR the log hasn't been rotated in the specified, it will be rotated. Using the older size option, the time-based rotation was ignored.

@jleveque jleveque self-assigned this Apr 24, 2017
@jleveque jleveque requested review from lguohan and stcheng April 24, 2017 19:42
lguohan
lguohan reviewed Apr 24, 2017
View reviewed changes
files/image_config/logrotate.d/rsyslog
missingok
notifempty
compress
delaycompress
sharedscripts
postrotate
invoke-rc.d rsyslog rotate > /dev/null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvoke-rc.d rsyslog rotate > /dev/null [](start = 9, length = 37)

in /etc/init.d/rsyslog, rotate is doing the kill HUP. why not use invoke-rc.d rsyslog rotate?

Copy link
Contributor Author

@jleveque jleveque Apr 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not working properly. It was confirmed as a bug present in our version of init-system-helpers: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672218.

There seem to be two workarounds:

  1. service rsyslog rotate >/dev/null 2>&1 || true
  2. kill -HUP $(cat /var/run/rsyslogd.pid)

I have tested the latter solution. I did not try the former, as the || true seems a bit hacky. I can test it if you'd like.

lguohan
lguohan requested changes Apr 24, 2017
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

NStetskovych-zz
NStetskovych-zz reviewed Apr 24, 2017
View reviewed changes
Copy link
Contributor

@NStetskovych-zz NStetskovych-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/etc/init.d/rsyslog rotate > /dev/null
was solved this problem to me some time ago, not sure about now.

@jleveque jleveque merged commit f28790c into sonic-net:master Apr 25, 2017
@jleveque jleveque deleted the syslog_fixes branch April 25, 2017 00:55
@jleveque jleveque mentioned this pull request Apr 25, 2017
Closed
@jleveque jleveque mentioned this pull request Jul 30, 2019
Merged
lguohan pushed a commit that referenced this pull request Jul 31, 2019
@jleveque @lguohan
[sonic-utilities] Update submodule (#3235)
35989ab 
* src/sonic-utilities ee56d54...cb0e745 (11):
  > sonic_utilities: Support for DOM Threshold values for EEPROM dump
(#545)
  > [portstat] Fix portstat show RX_UTIL over 100% for 100G (#563)
  > sonic_installer: fix read-only filesystem support for firmware
update (#565)
  > Revert "show acl table command output should show binding column
correctly even with single port (#447)" (#589)
  > show acl table command output should show binding column correctly
even with single port (#447)
  > [config] Do no stop or restart dependent services (#582)
  > sfpshow: prevent 'show int trans eeprom --dom' from crashing (#567)
  > [warm-reboot] add docker upgrade --warm option and roll back support
(#559)
  > [ecnconfig] Validate input WRED parameters (#579)
  > [sonic-utilities] Add fstrim to reboot (#535)
  > Fixing the expected neighbor command due to change in output format
under sonic-buildimage/pull/3036 (#584)
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@jleveque
[sonic-utilities] Add fstrim to reboot (sonic-net#535)
f387dc5 
Signed-off-by: Harish Venkatraman <[email protected]>
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Nov 22, 2019
@lguohan
[submodule]: update sonic-sairedis
1306bff 
* 5337490 2019-11-22 | Send port status notification when creating hostif interface (sonic-net#535) [Kamil Cudnik]

Signed-off-by: Guohan Lu <[email protected]>
@lguohan lguohan mentioned this pull request Nov 22, 2019
Merged
lguohan added a commit that referenced this pull request Nov 22, 2019
@lguohan
[submodule]: update sonic-sairedis (#3804)
a542335 
* 5337490 2019-11-22 | Send port status notification when creating hostif interface (#535) [Kamil Cudnik]

Signed-off-by: Guohan Lu <[email protected]>
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Jan 10, 2020
@lguohan @zhenggen-xu
[submodule]: update sonic-sairedis (sonic-net#3804)
c94547c 
* 5337490 2019-11-22 | Send port status notification when creating hostif interface (sonic-net#535) [Kamil Cudnik]

Signed-off-by: Guohan Lu <[email protected]>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@pavel-shirshov @lguohan
Create empty ready lists for buffers by default (sonic-net#535)
5d31b2d 
* Pospone QueueMap initialization until activation of counters

* Generate queue maps only for front panel ports

* Create empty buffer lists by default
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
@kcudnik @lguohan
Send port status notification when creating hostif interface (sonic-n…
5337490 
…et#535)
@TACappleman TACappleman mentioned this pull request Oct 26, 2021
Merged
TACappleman added a commit to Metaswitch/sonic-buildimage that referenced this pull request Oct 27, 2021
@TACappleman
[swss-common] Update swss-common submodule
d65ae43 
[schema] Add EXP to TC map config table (sonic-net#537)
[CI]: Swap the python code coverage report with the cpp report (sonic-net#544)
Remove SWIG generated files from coverage report (sonic-net#542)
Update database defintions for PINs / P4Runtime (sonic-net#536)
[ci]: Support code coverage (sonic-net#539)
Fix the option missing in kernel config issue (sonic-net#541)
Add SRV6 APP tables (sonic-net#538)
[schema] Rename CBF config tables (sonic-net#535)
lguohan pushed a commit that referenced this pull request Oct 28, 2021
@TACappleman
[swss-common] Update swss-common submodule (#9073)
aab689e 
[schema] Add EXP to TC map config table (#537)
[CI]: Swap the python code coverage report with the cpp report (#544)
Remove SWIG generated files from coverage report (#542)
Update database defintions for PINs / P4Runtime (#536)
[ci]: Support code coverage (#539)
Fix the option missing in kernel config issue (#541)
Add SRV6 APP tables (#538)
[schema] Rename CBF config tables (#535)
mssonicbld added a commit that referenced this pull request Nov 28, 2024
@mssonicbld
[submodule] Update submodule sonic-platform-daemons to the latest HEA…
24fb3e1 
…D automatically (#20957)

#### Why I did it
src/sonic-platform-daemons
```
* 57f0448 - (HEAD -> master, origin/master, origin/HEAD) [lag_id] Add lagid to free_list when LC absent for 30 minutes (#542) (9 hours ago) [Marty Y. Lok]
* 3624cb7 - [stormond] Added new dynamic field 'last_sync_time' to STATE_DB (#535) (21 hours ago) [Ashwin Srinivasan]
* 0431fa3 - Addition of DPU Chassis for thermalctld (#564) (24 hours ago) [Gagan Punathil Ellath]
```
#### How I did it
#### How to verify it
#### Description for the changelog
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
@mssonicbld @VladimirKuk
[submodule] Update submodule sonic-platform-daemons to the latest HEA…
96e6e0a 
…D automatically (sonic-net#20957)

#### Why I did it
src/sonic-platform-daemons
```
* 57f0448 - (HEAD -> master, origin/master, origin/HEAD) [lag_id] Add lagid to free_list when LC absent for 30 minutes (sonic-net#542) (9 hours ago) [Marty Y. Lok]
* 3624cb7 - [stormond] Added new dynamic field 'last_sync_time' to STATE_DB (sonic-net#535) (21 hours ago) [Ashwin Srinivasan]
* 0431fa3 - Addition of DPU Chassis for thermalctld (sonic-net#564) (24 hours ago) [Gagan Punathil Ellath]
```
#### How I did it
#### How to verify it
#### Description for the changelog
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jan 27, 2025
@r12f
Merge pull request sonic-net#535 from mssonicbld/cherry/msft-202412/2…
e95a415 
…1070

[action] [PR:21070] [sonic-mgmt-docker-image] Support ptf dataplane packet poll with multiple ptf nn agents connection
yanjundeng pushed a commit to yanjundeng/sonic-buildimage that referenced this pull request Apr 23, 2025
@mssonicbld @yanjundeng
[submodule] Update submodule sonic-platform-daemons to the latest HEA…
6594841 
…D automatically (sonic-net#20957)

#### Why I did it
src/sonic-platform-daemons
```
* 57f0448 - (HEAD -> master, origin/master, origin/HEAD) [lag_id] Add lagid to free_list when LC absent for 30 minutes (sonic-net#542) (9 hours ago) [Marty Y. Lok]
* 3624cb7 - [stormond] Added new dynamic field 'last_sync_time' to STATE_DB (sonic-net#535) (21 hours ago) [Ashwin Srinivasan]
* 0431fa3 - Addition of DPU Chassis for thermalctld (sonic-net#564) (24 hours ago) [Gagan Punathil Ellath]
```
#### How I did it
#### How to verify it
#### Description for the changelog
jianyuewu pushed a commit to jianyuewu/sonic-buildimage that referenced this pull request May 7, 2025
@mssonicbld
Override MaxDurationDPInit through software for values <= 1s (sonic-n…
bede51f 
…et#535)

<!-- Provide a general summary of your changes in the Title above -->

#### Description
<!--
 Describe your changes in detail
-->
For some transceivers, the `MaxDurationDPInit` encoded in EEPROM might be lesser than the actual time taken to reach DP init state by the transceivers. This causes the CMIS initialization to fail with the below error
```
Jan 23 19:28:12.207053 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_INIT, appl 1 host_lane_count 8 retries=0
Jan 23 19:28:12.221832 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: DpInit duration 0.5 secs
Jan 23 19:28:13.230593 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_TXON, appl 1 host_lane_count 8 retries=0
Jan 23 19:28:13.234448 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: timeout for 'DataPathInitialized' <<-- Error
Jan 23 19:28:14.250133 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: 400G, lanemask=0xff, state=INSERTED, appl 1 host_lane_count 8 retries=1
Jan 23 19:28:14.315148 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: Setting appl=1
Jan 23 19:28:14.380452 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: Setting host_lanemask=0xff
Jan 23 19:28:14.511850 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: Setting media_lanemask=0xf
Jan 23 19:28:14.567454 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: force Datapath reinit
Jan 23 19:28:15.575785 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_DEINIT, appl 1 host_lane_count 8 retries=1
Jan 23 19:28:15.598574 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: DpDeinit duration 0.1 secs, modulePwrUp duration 10.0 secs
Jan 23 19:28:16.606588 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: 400G, lanemask=0xff, state=AP_CONFIGURED, appl 1 host_lane_count 8 retries=1
Jan 23 19:28:17.640929 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_INIT, appl 1 host_lane_count 8 retries=1
Jan 23 19:28:17.656010 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: DpInit duration 0.5 secs
Jan 23 19:28:18.664305 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_TXON, appl 1 host_lane_count 8 retries=1
Jan 23 19:28:18.668263 DUT1 NOTICE pmon#xcvrd[36]: CMIS: Ethernet96: timeout for 'DataPathInitialized' <<-- Error
```
Hence, we need to relax this stringent requirement from software to successfully allow CMIS initialization for such transceivers.

#### Motivation and Context
<!--
 Why is this change required? What problem does it solve?
 If this pull request closes/resolves an open Issue, make sure you
 include the text "fixes #xxxx", "closes #xxxx" or "resolves #xxxx" here
-->
For transceivers with `MaxDurationDPInit` <= 1s, the CMIS driver will increase the timeout value to 10 times of the corresponding `MaxDurationDPInit` value advertised in the EEPROM to allow the transceiver to reach DP init state successfully.

#### How Has This Been Tested?
<!--
 Please describe in detail how you tested your changes.
 Include details of your testing environment, and the tests you ran to
 see how your change affects other areas of the code, etc.
-->
For a transceiver with `MaxDurationDPInit` = 0.5s, the `get_datapath_init_duration` API returned a value of 5s.
```
PATELMI@DUT1:~$ sudo sfputil read-eeprom -p Ethernet96 -n 1 -o 144 -s 1
 00000090 45 |E|
PATELMI@DUT1:~$
.
.
.
Jan 24 06:09:29.896666 DUT1 NOTICE pmon#xcvrd[101451]: CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_INIT, appl 1 host_lane_count 8 retries=0
Jan 24 06:09:29.912270 DUT1 NOTICE pmon#xcvrd[101451]: CMIS: Ethernet96: DpInit duration 5.0 secs
Jan 24 06:09:30.920209 DUT1 NOTICE pmon#xcvrd[101451]: CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_TXON, appl 1 host_lane_count 8 retries=0
Jan 24 06:09:32.957135 DUT1 NOTICE pmon#xcvrd[101451]: message repeated 2 times: [ CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_TXON, appl 1 host_lane_count 8 retries=0]
Jan 24 06:09:32.957135 DUT1 NOTICE pmon#xcvrd[101451]: CMIS: Ethernet96: Turning ON tx power
Jan 24 06:09:33.964916 DUT1 NOTICE pmon#xcvrd[101451]: CMIS: Ethernet96: 400G, lanemask=0xff, state=DP_ACTIVATION, appl 1 host_lane_count 8 retries=0
Jan 24 06:09:33.968630 DUT1 NOTICE pmon#xcvrd[101451]: CMIS: Ethernet96: READY
```

#### Additional Information (Optional)
MSFT ADO - 31007979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NStetskovych-zz NStetskovych-zz NStetskovych-zz left review comments

@lguohan lguohan lguohan approved these changes

@stcheng stcheng Awaiting requested review from stcheng

Assignees

@jleveque jleveque

Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleveque @lguohan @NStetskovych-zz