Skip to content

[docker-orchagent]: Fix qos configuration for TD2 platform #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2017
Merged

[docker-orchagent]: Fix qos configuration for TD2 platform #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dockers/docker-orchagent/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ SWSSCONFIG_ARGS="00-copp.config.json "

if [ "$HWSKU" == "Force10-S6000" ]; then
ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
SWSSCONFIG_ARGS+="td2.32ports.qos.json td2.32ports.buffers.json "
SWSSCONFIG_ARGS+="td2.32ports.buffers.json td2.32ports.qos.json "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to know more information about this. As I don't see any failures while applying the configurations, why the order of applying these files matters? Are there any dependencies in between some SAI objects? How to ensure the order? I think it is better also to fix the dependency in orchagent code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by applying buffer configuration after qos configuration we rewrite "PORT_QOS_MAP_TABLE:*: pfc_enable" settings. At least I see there're issues with pfc frame generation.

Sorry. I don't have more information for you.

Do you remember last time I split the buffer/qos configuration files into chunks? sonic-net/sonic-swss@8056a15

I did this because it was just one possibility to make it working. That time you told me we're having bugs in saibcm.

So this time I believe we have some bugs with saibcm too.

Copy link
Contributor

@stcheng stcheng Mar 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will double check. Thanks for the information. Please let me hold this pull request for a moment to investigate.

elif [ "$HWSKU" == "Force10-S6100" ]; then
ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
elif [ "$HWSKU" == "Force10-Z9100" ]; then
ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
elif [ "$HWSKU" == "Arista-7050-QX32" ]; then
ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
SWSSCONFIG_ARGS+="td2.32ports.qos.json td2.32ports.buffers.json "
SWSSCONFIG_ARGS+="td2.32ports.buffers.json td2.32ports.qos.json "
elif [ "$HWSKU" == "Arista-7060-CX32S" ]; then
ORCHAGENT_ARGS+="-m $MAC_ADDRESS"
elif [ "$HWSKU" == "AS7512" ]; then
Expand Down