-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Services] Restart Telemetry service upon unexpected critical process exit. #3768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong Zhao <[email protected]>
processes file into dockerfile.j2. Signed-off-by: Yong Zhao <[email protected]>
supervisord conf file. Signed-off-by: Yong Zhao <[email protected]>
wants to restart this container more than 3 times in 20 minutes. Signed-off-by: Yong Zhao <[email protected]>
into shared Makefile telemetry.mk. Signed-off-by: Yong Zhao <[email protected]>
jleveque
suggested changes
Nov 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also make the following changes to supervisord.conf:
- rsyslogd:
autorestart=true
- telemetry:
autorestart=false
- dialout:
autorestart=false
I will do that. |
auto-restart of rsyslogd and disable auto-restart of another two processes telemetry and dialout. Signed-off-by: Yong Zhao <[email protected]>
jleveque
suggested changes
Nov 15, 2019
supervisord conf file. Signed-off-by: Yong Zhao <[email protected]>
jleveque
approved these changes
Nov 16, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
… exit. (sonic-net#3768) Signed-off-by: Yong Zhao <[email protected]>
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Mar 24, 2025
…atically (sonic-net#916) #### Why I did it src/sonic-utilities ``` * 36ba067f - (HEAD -> 202412, origin/202412) Merge pull request sonic-net#156 from mssonicbld/sonicbld/202412-merge (11 hours ago) [mssonicbld] * dcf62147 - Merge branch '202411' of https://github.com/sonic-net/sonic-utilities into 202412 (16 hours ago) [Sonic Automation] * b197a610 - [db_migrator] Migrate tunnel table (sonic-net#3806) (4 days ago) [mssonicbld] * 5b765f3f - [GCU] Add data acl table and rule check (sonic-net#3807) (4 days ago) [mssonicbld] * 04bc01d9 - [Techsupport]Add show route-map command to frr dumps in techsupport (sonic-net#3803) (5 days ago) [mssonicbld] * 7a3f4ad6 - Fix the interface name length validation for subinterface (sonic-net#3799) (7 days ago) [mssonicbld] * 357f95d3 - enable pfcwd for backplane ports (sonic-net#3796) (11 days ago) [mssonicbld] * 7f316e7c - revert YANG check in db_migrator (sonic-net#3794) (12 days ago) [mssonicbld] * c01a4f5f - Add namespace support for show interface neighbor expected (sonic-net#3790) (2 weeks ago) [mssonicbld] * 17a7b18b - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3780) (3 weeks ago) [mssonicbld] * 5cc10123 - [202411][FC] remove FC delay field (sonic-net#3768) (3 weeks ago) [Stepan Blyshchak] * 8ceba38b - [QOS] Skip showing unnecessary warning message (sonic-net#3762) (5 weeks ago) [mssonicbld] * 04b60e22 - Fix call for spanning-tree commands in dump script (sonic-net#3752) (6 weeks ago) [mssonicbld] * bbe29aee - [show][interface] Add changes for show interface errors command (sonic-net#3749) (6 weeks ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Restart Telemetry service if one of critical processes running in Telemetry container exited or crashed abnormally.
How I did it
Generally I follow the framework created by Joe to implement this feature in Telemetry container.
First, add supervisor-proc-exit-listener event listener option in Supervisord configuration file in Telemetry docker container. Supervisord will read a list of critical processes for which to monitor the unexpected crashed and exited.
Second, configure telemetry.service to always auto-restart the service if it stops, with a delay of 30 seconds. Also set a rate limit of 3 restarts within 20 minutes (1200 seconds).
How to verify it
On your switch device, please use docker ps command to list all running docker containers.
Then use docker exec -it container_id bash to login target container. Typing top command
on the shell will display all the processes dynamically and you will spot the process id of one
of the critical processes. Finally type the command kill -9 process_id to terminate one process.
After exiting the container, you can use watch -n 1 docker ps to dynamically see the restart
of Telemetry container.