Skip to content

[Mellanox] Support SN3800 in platform api #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2019
Merged

[Mellanox] Support SN3800 in platform api #3593

merged 2 commits into from
Oct 16, 2019

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Oct 12, 2019 •
edited
Loading

- What I did
Support SN3800 in platform api

- How I did it

  1. add port position tuple for SN3800

- How to verify it
make sure chassis loaded successfully and check whether all the sfps are in the STATE_DB

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[sonic_platform]Support 3800
3518e31 
1. add port position tuple for 3800
@stephenxs stephenxs marked this pull request as ready for review October 12, 2019 01:20
nazariig
nazariig reviewed Oct 12, 2019
View reviewed changes
liat-grozovik
liat-grozovik reviewed Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U mentioned in the commint that you added port position tuple for 3800 but it actually deleted and was not added. Should you update the commit message?

Please use SN3800 as the product name.

@stephenxs stephenxs changed the title [Mellanox] Support 3800 in platform api [Mellanox] Support SN3800 in platform api Oct 15, 2019
@stephenxs
Copy link
Collaborator Author

U mentioned in the commint that you added port position tuple for 3800 but it actually deleted and was not added. Should you update the commit message?

Please use SN3800 as the product name.

  1. Can you elaborate it? Why do you think it was deleted?
  2. Title and commits updated, using SN3800.

@lguohan
Copy link
Collaborator

lguohan commented Oct 15, 2019

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Oct 15, 2019

retest vs please

@liat-grozovik liat-grozovik merged commit 249e858 into sonic-net:master Oct 16, 2019
@stephenxs stephenxs deleted the support3800 branch October 16, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keboliu keboliu keboliu approved these changes

@nazariig nazariig nazariig approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

Assignees
No one assigned
Labels
Enhancement ➕ Platform: Mellanox
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stephenxs @lguohan @keboliu @nazariig @liat-grozovik @jleveque