-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Handle minigraph.xml "OutAcl" keyword and support Acl on VlanInterface #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mssonicbld
added a commit
that referenced
this pull request
Sep 12, 2024
…atically (#20236) #### Why I did it src/sonic-utilities ``` * da63e5b2 - (HEAD -> 202311, origin/202311) [sfputil] Configure the debug loopback mode only on the relevant lanes of the logical port (#3485) (59 minutes ago) [Xinyu Lin] * b3ed805a - sonic-installer: enhance next image detection for Aboot (#3433) (19 hours ago) [Samuel Angebault] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Sep 14, 2024
…atically (#20240) #### Why I did it src/sonic-utilities ``` * 2cb8cc6 - (HEAD -> master, origin/master, origin/HEAD) [sfputil] Configure the debug loopback mode only on the relevant lanes of the logical port (#3485) (2 days ago) [Xinyu Lin] * 1aac5e2 - [VoQ chassis] : Script to debug packet drops (#3536) (2 days ago) [Vineet Mittal] * ad5b0c0 - [Mellanox] Add SPC5 to generic config updater file (#3542) (3 days ago) [noaOrMlnx] * 8fa076d - sonic-installer: enhance next image detection for Aboot (#3433) (3 days ago) [Samuel Angebault] ``` #### How I did it #### How to verify it #### Description for the changelog
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…atically (sonic-net#20240) #### Why I did it src/sonic-utilities ``` * 2cb8cc6 - (HEAD -> master, origin/master, origin/HEAD) [sfputil] Configure the debug loopback mode only on the relevant lanes of the logical port (sonic-net#3485) (2 days ago) [Xinyu Lin] * 1aac5e2 - [VoQ chassis] : Script to debug packet drops (sonic-net#3536) (2 days ago) [Vineet Mittal] * ad5b0c0 - [Mellanox] Add SPC5 to generic config updater file (sonic-net#3542) (3 days ago) [noaOrMlnx] * 8fa076d - sonic-installer: enhance next image detection for Aboot (sonic-net#3433) (3 days ago) [Samuel Angebault] ``` #### How I did it #### How to verify it #### Description for the changelog
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
…atically (sonic-net#20240) #### Why I did it src/sonic-utilities ``` * 2cb8cc6 - (HEAD -> master, origin/master, origin/HEAD) [sfputil] Configure the debug loopback mode only on the relevant lanes of the logical port (sonic-net#3485) (2 days ago) [Xinyu Lin] * 1aac5e2 - [VoQ chassis] : Script to debug packet drops (sonic-net#3536) (2 days ago) [Vineet Mittal] * ad5b0c0 - [Mellanox] Add SPC5 to generic config updater file (sonic-net#3542) (3 days ago) [noaOrMlnx] * 8fa076d - sonic-installer: enhance next image detection for Aboot (sonic-net#3433) (3 days ago) [Samuel Angebault] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Parse OutAcl keyword. Config now adds "stage" keyword to generated config with Ingress for InAcl and egress for OutAcl
Also allow Vlan interfaces on Acl configuration
- How I did it
Updated minigraph.py in sonic-config-engine as well as associated test scripts
- How to verify it
Added below section in minigraph.xml and successfully parse it
<AclInterfaces> <AclInterface><ElementType>DataAcl</ElementType><Name i:nil="true"/><AttachTo>Vlan101</AttachTo><OutAcl>v4-A-Out</OutAcl><Type>DataPlane</Type><File i:nil="true"/></AclInterface> <AclInterface><ElementType>DataAcl</ElementType><Name i:nil="true"/><AttachTo>Vlan101</AttachTo><OutAcl>v6-A-Out</OutAcl><Type>DataPlane</Type><File i:nil="true"/></AclInterface> <AclInterface><ElementType>DataAcl</ElementType><Name i:nil="true"/><AttachTo>Vlan102</AttachTo><OutAcl>v4-b-Out</OutAcl><Type>DataPlane</Type><File i:nil="true"/></AclInterface> <AclInterface><ElementType>DataAcl</ElementType><Name i:nil="true"/><AttachTo>Vlan102</AttachTo><OutAcl>v6-b-Out</OutAcl><Type>DataPlane</Type><File i:nil="true"/></AclInterface> <AclInterface><ElementType>DataAcl</ElementType><Name i:nil="true"/><AttachTo>VTY_LINE</AttachTo><InAcl>ipv6-ssh-only</InAcl><Type>SSH</Type><File i:nil="true"/></AclInterface> </AclInterfaces>
/usr/local/bin/sonic-cfggen -H -m minigraph.xml -j /etc/sonic/init_cfg.json --print-data "ACL_TABLE": { "v4-b-Out": { "policy_desc": "v4-b-Out", "ports": [ "Vlan102" ], "stage": "egress", "type": "L3" }, "v6-b-Out": { "policy_desc": "v6-b-Out", "ports": [ "Vlan102" ], "stage": "egress", "type": "L3" }, "v4-A-out": { "policy_desc": "v4-A-out", "ports": [ "Vlan101" ], "stage": "egress", "type": "L3" }, "v6-A-out": { "policy_desc": "v6-A-out", "ports": [ "Vlan101" ], "stage": "egress", "type": "L3" },
- Description for the changelog
Handle "OutAcl" keyword in minigraph.xml for egress ACLs. Support Vlan interfaces for ACL configuration.
- A picture of a cute animal (not mandatory but encouraged)