[Libnl] Always report LINK_ATTR_IFINDEX when available #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <[email protected]>
Signed-off-by: Ying Xie <[email protected]>
|
I don't understand how it could help us. |
|
I had the same question when I looked at the change again today. I think what happens is that it removed the LINK_ATTR_IFNAME bit from ce_mask. But I admit I am not 100% sure. We can leave this change out for now and collect more information. I think I can proof one way or another with a debug change that I will run offline. |
mihirpat1
pushed a commit
to mihirpat1/sonic-buildimage
that referenced
this pull request
Jun 14, 2023
* swss: Fix egress queue counters in voq systems. * In voq systems, the buffer profiles are defined on sysports.So the phy ports do not have buffer queue config and queuesStateVector built by getQueueConfigurations in flexcounterorch never has phy ports in voq systems. So in voq systems, always enable egress queue counters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Justifications: some client (libteamd) experienced issue, if they didn't get interface name from libnl upon receiving the first notification after LINK_ATTR_IFNAME is set, (before this change) these client wouldn't be able to query interface name later because libnl won't return interface name after LINK_ATTR_IFNAME flag is removed.
This PR complements #2699
- How to verify it
This issue was original discovered in continuous warm-reboot test at 182nd iteration. It is not super repeatable. With the fix, now the test passed that iteration. The test will go on for another day or 2 until we can safely say it is good. Putting up this review for early discussions.