-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[KubeSonic] Add bmp container watchdog #22352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
8f0e02b
to
f00ce64
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
|
||
fn main() { | ||
// Start a HTTP server listening on port 50058 | ||
let listener = TcpListener::bind("127.0.0.1:50058") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
50058 is an ephemeral port ( /proc/sys/net/ipv4/ip_local_port_range).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just refer existing code
let listener = TcpListener::bind("127.0.0.1:50058") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maipbui
Could you please check this as well?
If we bind a TCP server to the port in the dynamic range that isn’t reserved in /proc/sys/net/ipv4/ip_local_reserved_ports, bind() may sometimes fail because another program might be using that port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this PR: #17907, so using 50058 is also correct now.
Why I did it
Add bmp container watchdog, so that bmp could be managed/upgraded via k8s path.
Work item tracking
How I did it
Add watchdog docker container with health check returned directly, will fill health check logic in following PR.
How to verify it
image verfication.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)