Change PTF docker image to use GNXI from google repo #22062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hdwhdw
reviewed
Mar 20, 2025
There was a problem hiding this comment.
LGTM but just curious, how do you get these patches, can we have some metadata here like:
# Metadata
# Source: https://github.com/lguohan/gnxi
# Commit: <commit-sha>
# Author: Author Name <[email protected]>
# Date: YYYY-MM-DD
# Description: Add xpath_target option
at the top of these .patch file?
These patches were commits made to previous forked repo. |
zbud-msft
approved these changes
Mar 20, 2025
ganglyu
approved these changes
Mar 21, 2025
qiluo-msft
approved these changes
Mar 21, 2025
|
Verified again, the patched files are exactly same:
liuh@liuh-vm0: |
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
Change PTF docker image to use GNXI from google repo #### Why I did it Currently PTF docker using GNXI from a private repo #### How I did it Change PTF docker image to use GNXI from google repo Generate patch file from private repo and apply to google repo. #### How to verify it Pass all test case. Download ptf docker image and verified the patched GNXI is same with private repo. #### Description for the changelog Change PTF docker image to use GNXI from google repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change PTF docker image to use GNXI from google repo
Why I did it
Currently PTF docker using GNXI from a private repo
Work item tracking
How I did it
Change PTF docker image to use GNXI from google repo
Generate patch file from private repo and apply to google repo.
How to verify it
Pass all test case.
Download ptf docker image and verified the patched GNXI is same with private repo.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Change PTF docker image to use GNXI from google repo
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)