[Build] Log improvement for package download failure #21905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gpunathilell <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Mar 17, 2025
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
#### Why I did it Currently, the log displayed during curl failure does not have enough information: `Try 5: /usr/bin/curl --retry-connrefused --retry 5 failed to get: -L` The array expansion is not done, and only the first parameter is printed (since the `log_err` function only prints `$1`). After the change: `Try 1: /usr/bin/curl --retry-connrefused --retry 5 failed to get: -L -f -o target/debs/bookworm/libgrpc-dev-dbgsym_1.39.0-1_arm64.deb https://github.com/user/a/b/c/d/test1.deb. Retry..` This would help in debugging. #### Description for the changelog Write a short (one-line) summary that describes the changes in this pull request for inclusion in the changelog: #### Link to config_db schema for YANG module changes Provide a link to `config_db` schema for the table for which the YANG model is defined. Link should point to the correct section on [Configuration.md](https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Currenty the log displayed during curl failure does not have enough information:
Try 5: /usr/bin/curl --retry-connrefused --retry 5 failed to get: -LThe array expansion is not done and only the first parameter is printed (since log_err function only prints $1)
After change:
Try 1: /usr/bin/curl --retry-connrefused --retry 5 failed to get: -L -f -o target/debs/bookworm/libgrpc-dev-dbgsym_1.39.0-1_arm64.deb https://github.com/user/a/b/c/d/test1.deb. Retry..Which would help in debugging
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)