[Mellanox] Fix the issue with sensors with discrete indexes initialization #21856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Feb 26, 2025
bingwang-ms
approved these changes
Feb 26, 2025
|
@prgeor Can you help review. |
|
MSFT ADO: 31476170 |
prgeor
approved these changes
Feb 26, 2025
11 tasks
|
Cherry-pick PR to 202411: #21890 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
miatttao
pushed a commit
to miatttao/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
…ation. (sonic-net#21856) - Why I did it Fix the issue with the position calculation of the sensors with discrete indexes. - How I did it Pass the base position into create_discrete_thermal function instead of initializing the position with 1. - How to verify it Run snmp/test_snmp_phy_entity.py sonic-mgmt test on the platform with discrete sensors.
prabhataravind
pushed a commit
to prabhataravind/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
…ation. (sonic-net#21856) - Why I did it Fix the issue with the position calculation of the sensors with discrete indexes. - How I did it Pass the base position into create_discrete_thermal function instead of initializing the position with 1. - How to verify it Run snmp/test_snmp_phy_entity.py sonic-mgmt test on the platform with discrete sensors.
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
…ation. (sonic-net#21856) - Why I did it Fix the issue with the position calculation of the sensors with discrete indexes. - How I did it Pass the base position into create_discrete_thermal function instead of initializing the position with 1. - How to verify it Run snmp/test_snmp_phy_entity.py sonic-mgmt test on the platform with discrete sensors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix the issue with the position calculation of the sensors with discrete indexes.
Work item tracking
How I did it
Pass the base position into
create_discrete_thermalfunction instead of initializing the position with 1.How to verify it
Run
snmp/test_snmp_phy_entity.pysonic-mgmt test on the platform with discrete sensors.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)