Improve GNMI_CLIENT_CERT table to support multiple roles. #21849
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
azpw command does not work, close and reopen to trigger build |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
test case in gnmi/test_gnmi_configdb.py failed because yang validation break. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
force-pushed
the
dev/liuh/gnmi_multiple_role
branch
from
9d04798 to
fcfff8d
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This PR depends on sonic-gnmi submodule update: |
Why I did it GNMI service will change to mapping cname to a role list: sonic-net/sonic-buildimage#21849 To make sure GNMI test case in sonic-mgmt can pass with/without this change, we need improve test case to handle both case. Work item tracking Microsoft ADO: 31561802 How I did it Ignore test case bug github issue: #17876 Change GNMI setup code to handle role list by check yang model How to verify it Pass all test case.
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Could you add HLD PR into this PR description? |
I will update when Gang's PR ready. |
| @@ -1414,10 +1414,14 @@ | |||
| }, | |||
| "GNMI_CLIENT_CERT": { | |||
| "testcert1": { | |||
| "role": "RW" | |||
| "role": [ | |||
| "RW" | |||
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=3)
Please fix mixing tab and space.
| }, | ||
| "testcert2": { | ||
| "role": "RO" | ||
| "role": [ | ||
| "RO" |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=3)
The same. #Closed
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Improve GNMI_CLIENT_CERT table to support multiple roles.
Why I did it
GNMI need support multiple roles.
HLD: sonic-net/SONiC#1967
Work item tracking
How I did it
Change GNMI_CLIENT_CERT table yang model.
How to verify it
Pass all test case.
This PR depends on following PRs:
sonic-net/sonic-gnmi#366
sonic-net/sonic-mgmt#17866
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Improve GNMI_CLIENT_CERT table to support multiple roles.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)