Use software_bfd instead of switch_type. #21794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kperumalbfn
reviewed
Mar 13, 2025
| config_db.connect() | ||
| features = config_db.get_table('FEATURE') | ||
| if 'software_bfd' in features and 'state' in features['software_bfd'] and features['software_bfd']['state'] == 'enabled': | ||
| log_notice("software_bfd feature is enabled, starting bfd manager") | ||
| managers.append(BfdMgr(common_objs, "STATE_DB", swsscommon.STATE_BFD_SOFTWARE_SESSION_TABLE_NAME)) |
There was a problem hiding this comment.
Thanks @dypet could you confirm if all the tests are passing with the change.
There was a problem hiding this comment.
Are we enabling software_bfd feature by default in smartswitch?
There was a problem hiding this comment.
Tests are passing, should azure pipeline be retriggered to get a more recent run? Planning to add software_bfd=enabled to initial config for DPU
There was a problem hiding this comment.
@dypet Please enable software_bfd in the next PR and check the sanity.
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
Use software_bfd instead of switch_type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Request in sonic-net/sonic-swss#3406 to allow software BFD to be enabled independent of switch_type 'dpu'.
Work item tracking
How I did it
Added checks for new config DB entry instead,
"FEATURE": {
"software_bfd": {
"state": "enabled"
}
}
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)