[sonic-utilities]: Update submodule #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Luo <[email protected]>
lguohan
approved these changes
Oct 19, 2018
|
retest this please |
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Mar 9, 2022
29d5d8d Use abort instead of exit in case calling SAI API failure (sonic-net#2170) 12f980c Fix issue config qos reload causing orchagent aborted via tracking dependencies among QoS tables (sonic-net#2116) 6e5ed1c [chassis][syncd][sai] Adjusting response timeout during syncd init (sonic-net#2159) 0a99f54 Try get port operational speed from STATE DB (sonic-net#2119) 828cccf [crm] Use sai_object_type_get_availability() API to get counters (sonic-net#2098) 18c73a1 Allow IPv4 link-local nexthops (sonic-net#1903) Signed-off-by: Stephen Sun <[email protected]>
liat-grozovik
pushed a commit
that referenced
this pull request
Mar 15, 2022
Update sonic-swss with the following changes: 29d5d8d Use abort instead of exit in case calling SAI API failure (#2170) 12f980c Fix issue config qos reload causing orchagent aborted via tracking dependencies among QoS tables (#2116) 6e5ed1c [chassis][syncd][sai] Adjusting response timeout during syncd init (#2159) 0a99f54 Try get port operational speed from STATE DB (#2119) 828cccf [crm] Use sai_object_type_get_availability() API to get counters (#2098) 18c73a1 Allow IPv4 link-local nexthops (#1903) Signed-off-by: Stephen Sun <[email protected]>
Ndancejic
pushed a commit
to Ndancejic/sonic-buildimage
that referenced
this pull request
May 3, 2022
…2170) - What I did Use abort instead of exit in case calling SAI API failure Currently, exit is used in functions handleSai{Create,Remove,Set,Get}Status on SAI failure while abort is used in some other functions on SAI failure. IMO using abort yields benefits: Consistent behavior in orchagent on SAI failure in mocked test, in case SAI failure occurs the test process will just exit silently, which makes it very difficult for developers to find out what happened. by using abort, a coredump will be generated, which helps developers nail down the issue. So we would like to use abort in all cases of receiving SAI failure. - Why I did it - How I verified it Manually test. Signed-off-by: Stephen Sun <[email protected]>
vadymhlushko-mlnx
pushed a commit
to vadymhlushko-mlnx/sonic-buildimage
that referenced
this pull request
Nov 11, 2022
…2174) #### What I did Fixes sonic-net#2170 Converting xpath to path: - There is only 1 case where the path is referring to the list itself. Example: ``` path="/BUFFER_PORT_EGRESS_PROFILE_LIST/Ethernet9/profile_list", xpath="/sonic-buffer-port-egress-profile-list:sonic-buffer-port-egress-profile-list/BUFFER_PORT_EGRESS_PROFILE_LIST/BUFFER_PORT_EGRESS_PROFILE_LIST_LIST[port='Ethernet9']/profile_list", ``` - There is no other case as we the list is just a single string, and we cannot refer to individual elements in string in ConfigDb. Converting path to xpath, there are 2 cases: - Xpath is pointing to leaf-list as a whole, return path of whole list ``` xpath="/sonic-buffer-port-egress-profile-list:sonic-buffer-port-egress-profile-list/BUFFER_PORT_EGRESS_PROFILE_LIST/BUFFER_PORT_EGRESS_PROFILE_LIST_LIST[port='Ethernet9']/profile_list", path="/BUFFER_PORT_EGRESS_PROFILE_LIST/Ethernet9/profile_list", ``` - Xpath is pointing to an element of the leaf-list, return path of whole list as well since it is not possible to point to specific element -- here we are pointing to the element `egress_lossy_profile` ``` xpath="/sonic-buffer-port-egress-profile-list:sonic-buffer-port-egress-profile-list/BUFFER_PORT_EGRESS_PROFILE_LIST/BUFFER_PORT_EGRESS_PROFILE_LIST_LIST[port='Ethernet9']/profile_list[.='egress_lossy_profile']", path="/BUFFER_PORT_EGRESS_PROFILE_LIST/Ethernet9/profile_list", ``` #### How I did it Only a single change if the xpath is pointing to a specific element, just return whole list token from ConfigDb format. Please note this solution is future proof, if ConfigDb changes how a list is saved as a string or json list, we don't care. #### How to verify it unit-test #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.