Skip to content

[YANG] Add missing field in port qos map #21677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2025
Merged

[YANG] Add missing field in port qos map #21677

merged 2 commits into from
Feb 10, 2025

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Feb 8, 2025 •
edited
Loading

Why I did it

Add missing field introduced from PR: #21395

Work item tracking
  • Microsoft ADO (number only): 31313829

How I did it

Add the missing field

How to verify it

UT in sample_config_db.json
Also test in specific DUT after merge this change.
before:

sonic_yang(3):All Keys are not parsed in PORT_QOS_MAP
dict_keys(['Ethernet16'])
sonic_yang(3):exceptionList:["'tc_to_dscp_map'"]

after:

sonic_yang(6):Note: Below table(s) have no YANG models: bgpraw

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587 wen587 requested review from kperumalbfn and ganglyu February 8, 2025 05:33
@wen587 wen587 marked this pull request as ready for review February 8, 2025 05:41
@wen587 wen587 requested a review from qiluo-msft as a code owner February 8, 2025 05:41
@ganglyu
Copy link
Contributor

ganglyu commented Feb 8, 2025

Please add unit test

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft assigned kperumalbfn and unassigned ganglyu Feb 10, 2025
kperumalbfn
kperumalbfn approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kperumalbfn kperumalbfn merged commit 8295675 into sonic-net:master Feb 10, 2025
21 checks passed
@mssonicbld mssonicbld mentioned this pull request Feb 10, 2025
Merged
11 tasks
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21691

prabhataravind pushed a commit to prabhataravind/sonic-buildimage that referenced this pull request Mar 5, 2025
@wen587 @prabhataravind
[YANG] Add missing field in port qos map (sonic-net#21677)
c955984 
[YANG] Add missing field in port qos map
yanjundeng pushed a commit to yanjundeng/sonic-buildimage that referenced this pull request Apr 23, 2025
@wen587 @yanjundeng
[YANG] Add missing field in port qos map (sonic-net#21677)
a13cc7e 
[YANG] Add missing field in port qos map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kperumalbfn kperumalbfn kperumalbfn approved these changes

@ganglyu ganglyu ganglyu approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

Assignees

@kperumalbfn kperumalbfn

Labels
Approved for 202411 Branch Included in 202411 Branch Request for 202411 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wen587 @mssonicbld @ganglyu @kperumalbfn