Fix bmp critical_process duplicated bug #21588
Merged
+8
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
changed the title
8 tasks
qiluo-msft
approved these changes
Jan 31, 2025
11 tasks
|
Cherry-pick PR to 202411: #21599 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
prabhataravind
pushed a commit
to prabhataravind/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Why I did it Previously critical_process was defined duplicated like below: group:sonic-bmp program:openbmpd program:bmpcfgd which break some mgmt test cases. How I did it Get rid of group and follow most of other dockers to define program directly. How to verify it verified on DUT, program could work correctly.
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
Why I did it Previously critical_process was defined duplicated like below: group:sonic-bmp program:openbmpd program:bmpcfgd which break some mgmt test cases. How I did it Get rid of group and follow most of other dockers to define program directly. How to verify it verified on DUT, program could work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Previously critical_process was defined duplicated like below:
group:sonic-bmp
program:openbmpd
program:bmpcfgd
which break some mgmt test cases.
Work item tracking
How I did it
Get rid of group and follow most of other dockers to define program directly.
How to verify it
verified on DUT, program could work correctly.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)