-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix RPC container for Broadcom #21433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StormLiangMS
merged 1 commit into
sonic-net:master
from
saiarcot895:fix-syncd-rpc-container
Jan 15, 2025
Merged
Fix RPC container for Broadcom #21433
StormLiangMS
merged 1 commit into
sonic-net:master
from
saiarcot895:fix-syncd-rpc-container
Jan 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it. Signed-off-by: Saikrishna Arcot <[email protected]>
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
StormLiangMS
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it.
hi @kperumalbfn could you help to take this one for 202411? This is to fix the rpc build missing issue, without this PR, all QoS would be failed. |
11 tasks
Cherry-pick PR to 202411: #21518 |
prabhataravind
pushed a commit
to prabhataravind/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it.
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)