Skip to content

Fix RPC container for Broadcom #21433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

saiarcot895
Copy link
Contributor

libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it.

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

libthrift did not get installed in the Broadcom syncd RPC container.
However, syncd-rpc requires it.

Signed-off-by: Saikrishna Arcot <[email protected]>
@saiarcot895 saiarcot895 requested a review from lguohan as a code owner January 15, 2025 02:23
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 88c8ec9 into sonic-net:master Jan 15, 2025
11 checks passed
@saiarcot895 saiarcot895 deleted the fix-syncd-rpc-container branch January 15, 2025 20:00
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it.
@StormLiangMS
Copy link
Contributor

hi @kperumalbfn could you help to take this one for 202411? This is to fix the rpc build missing issue, without this PR, all QoS would be failed.

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21518

prabhataravind pushed a commit to prabhataravind/sonic-buildimage that referenced this pull request Mar 5, 2025
libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it.
yanjundeng pushed a commit to yanjundeng/sonic-buildimage that referenced this pull request Apr 23, 2025
libthrift did not get installed in the Broadcom syncd RPC container. However, syncd-rpc requires it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants